Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary updates for the new ternary operator added in PowerShell language #2142

Closed
daxian-dbw opened this issue Aug 19, 2019 · 2 comments
Closed
Labels
Area-Engine Needs: Fix Verification Please verify the fix for us!

Comments

@daxian-dbw
Copy link
Member

daxian-dbw commented Aug 19, 2019

The ternary operator will soon be added to the PowerShell language. Necessary updates may be needed for the vscode-powershell extension:

  1. New AST type TernaryExpressionAst is added. Changes are made to the visitors in PowerShell. The visitors in powershell extension may need to be updated too.
  2. The new ternary operator may cause syntax colorization issue.

/cc @rjmholt @TylerLeonhardt

@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 19, 2019
@TylerLeonhardt
Copy link
Member

The new ternary operator may cause syntax colorization issue.

Can you open an issue here:
https://github.com/PowerShell/EditorSyntax

@daxian-dbw
Copy link
Member Author

Done: PowerShell/EditorSyntax#184

@SydneyhSmith SydneyhSmith added Area-Engine Needs: Fix Verification Please verify the fix for us! and removed Needs: Triage Maintainer attention needed! labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Needs: Fix Verification Please verify the fix for us!
Projects
None yet
Development

No branches or pull requests

3 participants