Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better visual indicator that things are wrong #1592

Closed
PrzemyslawKlys opened this issue Oct 27, 2018 · 5 comments
Closed

Better visual indicator that things are wrong #1592

PrzemyslawKlys opened this issue Oct 27, 2018 · 5 comments
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@PrzemyslawKlys
Copy link
Contributor

Summary of the new feature

Right now when there is an error of sort VSCode the only visual indicator is the red file with a problem

image

Or none at all until you run it and it's too late.

Proposed technical implementation details (optional)

It would be great to show line where the first (I guess only 1st problem is visible, not all of them but if more then one, it would be great to see all) problem is more or less occurring. I sometimes see red file and then I search for a missing comma on 1000 line script. It's often easier to press F5, and see where it terminates.

@rkeithhill
Copy link
Collaborator

Have you checked out at the Problems view? Press ctrl+shift+m and it will show all detected problems in the script file, along with other files you have open. One thing the extension is not good about is removing entries from the Problems views after they have been fixed. Closing and re-opening the file will fix it but certainly is not ideal.

@PrzemyslawKlys
Copy link
Contributor Author

I saw this problems tab but it's often hidden (as Terminal is my main one). Not sure if you can divide that screen into 3 separate screens.

image

Also notice that I sometimes (often) use the screen like that:

image

And notice how it only started to see problem after I added another function Test { } with an error. All errors above were ignored and not visible until I've run it.

image

It also doesn't see problems with chars, or wrong lines but that is related to: PowerShell/PSScriptAnalyzer#1089 and

PowerShell/PSScriptAnalyzer#981 still I would expect PSSA to pick this up? Or I have wrong expectancy on this?

@rjmholt rjmholt added Issue-Enhancement A feature request (enhancement). and removed Issue-Bug A bug to squash. labels Nov 8, 2018
@TylerLeonhardt
Copy link
Member

So I think this is a combination of issues.

  1. that you're not getting results beck from PSScriptAnalyzer fast enough - dupe of Error/warning detection is randomly broken #1232

  2. that you'd like a feature from VSCode to split the bottom pane where you could have Problems next to, say, the Terminal.

@PrzemyslawKlys would you mind opening an issue on VSCode for that feature request?

Is it reasonable to close this as a dupe?

@PrzemyslawKlys
Copy link
Contributor Author

Sure. I'll open it up there. Actually, I often don't get "problems" at all or get them very late. But it's most likely related to all other issues I reported with relative vs absolute path and for some reason, it's displaying it late or never.

@PrzemyslawKlys
Copy link
Contributor Author

Like...

image

So many problems, and complains... that are not there anymore. I can press F5 and it will tell me there are no errors, yet VS Code claims there are 6 problems :-) including critical ones...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

4 participants