From 1d380941255332302ba17f8d52acfb3029e8de8f Mon Sep 17 00:00:00 2001 From: travis plunk Date: Fri, 6 May 2022 12:38:48 -0700 Subject: [PATCH 1/5] switch to using github action to verify PRs for markdown links --- .github/workflows/markdownLink.yml | 19 +++++++++++++++++++ .vsts-ci/misc-analysis.yml | 12 ------------ 2 files changed, 19 insertions(+), 12 deletions(-) create mode 100644 .github/workflows/markdownLink.yml diff --git a/.github/workflows/markdownLink.yml b/.github/workflows/markdownLink.yml new file mode 100644 index 000000000000..c7d4cbe07cf2 --- /dev/null +++ b/.github/workflows/markdownLink.yml @@ -0,0 +1,19 @@ +on: + pull_request: + branches: + - master + - 'release/**' + paths: + - '**.md' + +name: Check links for modified files +jobs: + markdown-link-check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 + with: + use-quiet-mode: 'yes' + use-verbose-mode: 'yes' + check-modified-files-only: 'yes' diff --git a/.vsts-ci/misc-analysis.yml b/.vsts-ci/misc-analysis.yml index b7d451ea1995..b9e19a2a505e 100644 --- a/.vsts-ci/misc-analysis.yml +++ b/.vsts-ci/misc-analysis.yml @@ -51,15 +51,3 @@ stages: dependsOn: [] jobs: - template: ./misc-analysis/mdSpell.yml -- stage: markdown_link - displayName: Markdown Link - dependsOn: [] - jobs: - - template: ./misc-analysis/generateMarkdownMatrix.yml - parameters: - jobName: generateMatrix - taskName: matrixTask - - template: ./misc-analysis/markdown.yml - parameters: - matrix: $[ dependencies.generateMatrix.outputs['matrixTask.matrix'] ] - dependsOn: generateMatrix From 215e1faa573ba67d1f69a98a8e7128bc0a1f4f0d Mon Sep 17 00:00:00 2001 From: travis plunk Date: Fri, 6 May 2022 12:44:02 -0700 Subject: [PATCH 2/5] break a link to see if it works --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fecde3d1e5ce..8e930f8fb218 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ Windows PowerShell specific issues should be reported with the [Feedback Hub app If you are new to PowerShell and would like to learn more, we recommend reviewing the [getting started][] documentation. -[getting started]: https://github.com/PowerShell/PowerShell/tree/master/docs/learning-powershell +[getting started]: https://github.com/PowerShells/PowerShell/tree/master/docs/learning-powershell ## Get PowerShell From ece98bc8f6b69887bbc3945e9c85a8c073dfe837 Mon Sep 17 00:00:00 2001 From: travis plunk Date: Fri, 6 May 2022 12:47:00 -0700 Subject: [PATCH 3/5] fix broken link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8e930f8fb218..564ca62581b8 100644 --- a/README.md +++ b/README.md @@ -142,7 +142,7 @@ For more information on how and why we built this dashboard, check out this [blo ## Discussions -[GitHub Discussions](https://docs.github.com/en/free-pro-team@latest/discussions/quickstart) is a feature to enable fluid and open discussions within the community +[GitHub Discussions](https://docs.github.com/discussions/quickstart) is a feature to enable fluid and open discussions within the community for topics that are not related to code, unlike issues. This is an experiment we are trying in our repositories to see if it helps move discussions out of issues so that issues remain actionable by the team or members of the community. From 4a309508b01e7ad72411a0d82e4c9b84efb0dd0b Mon Sep 17 00:00:00 2001 From: travis plunk Date: Fri, 6 May 2022 12:47:15 -0700 Subject: [PATCH 4/5] Revert "break a link to see if it works" This reverts commit 215e1faa573ba67d1f69a98a8e7128bc0a1f4f0d. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 564ca62581b8..1fb9ac898e57 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ Windows PowerShell specific issues should be reported with the [Feedback Hub app If you are new to PowerShell and would like to learn more, we recommend reviewing the [getting started][] documentation. -[getting started]: https://github.com/PowerShells/PowerShell/tree/master/docs/learning-powershell +[getting started]: https://github.com/PowerShell/PowerShell/tree/master/docs/learning-powershell ## Get PowerShell From 75d6bf1905d258d6d1481b5c3ede34ec41d290c1 Mon Sep 17 00:00:00 2001 From: travis plunk Date: Fri, 6 May 2022 12:54:49 -0700 Subject: [PATCH 5/5] Copy allowed failures from previous tests --- .github/workflows/markdown-link/config.json | 3 +++ .github/workflows/markdownLink.yml | 1 + 2 files changed, 4 insertions(+) create mode 100644 .github/workflows/markdown-link/config.json diff --git a/.github/workflows/markdown-link/config.json b/.github/workflows/markdown-link/config.json new file mode 100644 index 000000000000..ff00be38b451 --- /dev/null +++ b/.github/workflows/markdown-link/config.json @@ -0,0 +1,3 @@ +{ + "aliveStatusCodes": [504, 503, 403, 200] +} diff --git a/.github/workflows/markdownLink.yml b/.github/workflows/markdownLink.yml index c7d4cbe07cf2..732ab5d41594 100644 --- a/.github/workflows/markdownLink.yml +++ b/.github/workflows/markdownLink.yml @@ -17,3 +17,4 @@ jobs: use-quiet-mode: 'yes' use-verbose-mode: 'yes' check-modified-files-only: 'yes' + config-file: .github/workflows/markdown-link/config.json