New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more tests to be run in a container. #17294
Enable more tests to be run in a container. #17294
Conversation
@@ -257,7 +257,7 @@ Describe "Test-Connection" -tags "CI", "RequireSudoOnUnix" { | |||
# We skip the MtuSize detection tests when in containers, as the environments throw raw exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test comment should be updated since we no longer skip the test.
@@ -578,7 +578,7 @@ Describe "Help failure cases" -Tags Feature { | |||
|
|||
# under some conditions this does not throw, so include what we actually got | |||
$helpTopic = [guid]::NewGuid().ToString("N") | |||
{ & $command $helpTopic -ErrorAction Stop } | Should -Throw -ErrorId "HelpNotFound,Microsoft.PowerShell.Commands.GetHelpCommand" -Because "$(& $command $helpTopic -ea Ignore)" | |||
{ & $command $helpTopic -ErrorAction Stop } | Should -Throw -ErrorId "HelpNotFound,Microsoft.PowerShell.Commands.GetHelpCommand" -Because "A help topic was found for $helpTopic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ & $command $helpTopic -ErrorAction Stop } | Should -Throw -ErrorId "HelpNotFound,Microsoft.PowerShell.Commands.GetHelpCommand" -Because "A help topic was found for $helpTopic" | |
{ & $command $helpTopic -ErrorAction Stop } | Should -Throw -ErrorId "HelpNotFound,Microsoft.PowerShell.Commands.GetHelpCommand" -Because "A help topic was not found for $helpTopic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulHigin - actually in this case, it's an error if we find a help topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the test expectation is a thrown error because the topic is not found, and I feel the 'Because' text should make that clear.
/rebase |
Improve debugging output for online help test.
…e of different types (on windows).
…nt between native and managed.
5f18fba
to
3f2c3a3
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 |
🎉 Handy links: |
/backport to release/v7.0.12 |
/backport to release/v7.2.5 |
Started backporting to release/v7.0.12: https://github.com/PowerShell/PowerShell/actions/runs/2380466643
|
Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2380467497
|
@adityapatwardhan backporting to release/v7.0.12 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Enable more tests to be run in a container.
Using index info to reconstruct a base tree...
M src/Microsoft.PowerShell.Commands.Utility/commands/utility/SetDateCommand.cs
M src/System.Management.Automation/engine/Utils.cs
M test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
M test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Date.Tests.ps1
M test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1
M test/powershell/engine/Help/HelpSystem.Tests.ps1
Falling back to patching base and 3-way merge...
Auto-merging test/powershell/engine/Help/HelpSystem.Tests.ps1
CONFLICT (content): Merge conflict in test/powershell/engine/Help/HelpSystem.Tests.ps1
Auto-merging test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1
CONFLICT (content): Merge conflict in test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1
Auto-merging test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Date.Tests.ps1
Auto-merging test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
CONFLICT (content): Merge conflict in test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
Auto-merging src/System.Management.Automation/engine/Utils.cs
Auto-merging src/Microsoft.PowerShell.Commands.Utility/commands/utility/SetDateCommand.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Enable more tests to be run in a container.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@adityapatwardhan backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Enable more tests to be run in a container.
Using index info to reconstruct a base tree...
M test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
M test/powershell/engine/Help/HelpSystem.Tests.ps1
Falling back to patching base and 3-way merge...
Auto-merging test/powershell/engine/Help/HelpSystem.Tests.ps1
CONFLICT (content): Merge conflict in test/powershell/engine/Help/HelpSystem.Tests.ps1
Auto-merging test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Enable more tests to be run in a container.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
backported to 7.2 f1cb6d6 |
🎉 Handy links: |
/backport to release/v7.0.12 |
🎉 Handy links: |
Improve debugging output for online help test.
PR Summary
There are a number of tests which are disabled when run in a container. This PR re-enables all of them.
Notably, it removes the test which causes a browser to be launched in the shell as this is not available in a container (or server core). The functionality is still validated by verifying the URL that is opened, but does not launch the browser via a test hook.
This PR also improves a test for help failures by reporting the name of the topic that has been surprisingly found to aid in debugging.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).