New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using GitHub action to verify PRs for broken markdown links #17281
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Just curious, what is the gain by switching to GitHub action? |
See PR Context, we will only verify changed files. |
🎉 Handy links: |
/backport to release/v7.0.12 |
/backport to release/v7.2.5 |
Started backporting to release/v7.0.12: https://github.com/PowerShell/PowerShell/actions/runs/2380457950
|
Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2380458722
|
@adityapatwardhan backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: switch to using github action to verify PRs for markdown links
Using index info to reconstruct a base tree...
M .vsts-ci/misc-analysis.yml
Falling back to patching base and 3-way merge...
Auto-merging .vsts-ci/misc-analysis.yml
CONFLICT (content): Merge conflict in .vsts-ci/misc-analysis.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 switch to using github action to verify PRs for markdown links
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@adityapatwardhan backporting to release/v7.0.12 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: switch to using github action to verify PRs for markdown links
Using index info to reconstruct a base tree...
M .vsts-ci/misc-analysis.yml
Falling back to patching base and 3-way merge...
Auto-merging .vsts-ci/misc-analysis.yml
CONFLICT (content): Merge conflict in .vsts-ci/misc-analysis.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 switch to using github action to verify PRs for markdown links
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
ported to 7.2 7249200 |
🎉 Handy links: |
🎉 Handy links: |
PR Summary
Switch to using GitHub action to verify PRs for broken markdown links
PR Context
The action supports only verifying changed files.
Alive status codes come from the existing code here:
PowerShell/test/common/markdown-link/markdown-link.tests.ps1
Line 111 in a33b5d3
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).