Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore markdownlint tests #12539

Closed
xtqqczze opened this issue Apr 30, 2020 · 3 comments · Fixed by #12549
Closed

Restore markdownlint tests #12539

xtqqczze opened this issue Apr 30, 2020 · 3 comments · Fixed by #12549
Labels
Issue-Question ideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure

Comments

@xtqqczze
Copy link
Contributor

markdownlint tests were removed in #10163 due to a security issue in a dependancy (CVE-2019-10746).

According to snyk, markdownlint has no currently known vulnerabilities, so we should restore these tests.
@xtqqczze xtqqczze added the Issue-Question ideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a label Apr 30, 2020
@iSazonov iSazonov added the WG-Quality-Test issues in a test or in test infrastructure label May 1, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented May 1, 2020

/cc @TravisEz13 for conclusion.

@TravisEz13
Copy link
Member

spelling check doesn't work unless markdown is correctly formatted. I agree wit the proposal.

@xtqqczze xtqqczze mentioned this issue May 2, 2020
Merged
14 tasks
@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Jun 3, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉This issue was addressed in #12549, which has now been successfully released as v7.1.0-preview.4.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Question ideally support can be provided via other mechanisms, but sometimes folks do open an issue to get a Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore markdownlint tests xtqqczze/PowerShell
3 participants
@TravisEz13 @iSazonov @xtqqczze