From 72492008c676031ca2b1d26cc0f6dcc3a2056bc1 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 9 May 2022 11:42:15 -0700 Subject: [PATCH] Switch to using GitHub action to verify markdown links for PRs (#17281) --- .github/workflows/markdown-link/config.json | 3 +++ .github/workflows/markdownLink.yml | 20 ++++++++++++++++++++ .vsts-ci/misc-analysis.yml | 14 -------------- README.md | 2 +- 4 files changed, 24 insertions(+), 15 deletions(-) create mode 100644 .github/workflows/markdown-link/config.json create mode 100644 .github/workflows/markdownLink.yml diff --git a/.github/workflows/markdown-link/config.json b/.github/workflows/markdown-link/config.json new file mode 100644 index 000000000000..ff00be38b451 --- /dev/null +++ b/.github/workflows/markdown-link/config.json @@ -0,0 +1,3 @@ +{ + "aliveStatusCodes": [504, 503, 403, 200] +} diff --git a/.github/workflows/markdownLink.yml b/.github/workflows/markdownLink.yml new file mode 100644 index 000000000000..732ab5d41594 --- /dev/null +++ b/.github/workflows/markdownLink.yml @@ -0,0 +1,20 @@ +on: + pull_request: + branches: + - master + - 'release/**' + paths: + - '**.md' + +name: Check links for modified files +jobs: + markdown-link-check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 + with: + use-quiet-mode: 'yes' + use-verbose-mode: 'yes' + check-modified-files-only: 'yes' + config-file: .github/workflows/markdown-link/config.json diff --git a/.vsts-ci/misc-analysis.yml b/.vsts-ci/misc-analysis.yml index 5de5e28265aa..d1066b4701e4 100644 --- a/.vsts-ci/misc-analysis.yml +++ b/.vsts-ci/misc-analysis.yml @@ -90,20 +90,6 @@ jobs: condition: succeededOrFailed() workingDirectory: '$(repoPath)' - - ${{ if not(contains(variables['SYSTEM.COLLECTIONURI'],'mscodehub')) }}: - - pwsh: | - Import-module ./build.psm1 - $path = Join-Path -Path $pwd -ChildPath './commonTestResults.xml' - $results = invoke-pester -Script ./test/common -OutputFile $path -OutputFormat NUnitXml -PassThru - Write-Host "##vso[results.publish type=NUnit;mergeResults=true;runTitle=Common Tests;publishRunAttachments=true;resultFiles=$path;]" - if($results.TotalCount -eq 0 -or $results.FailedCount -gt 0) - { - throw "Markdown tests failed" - } - displayName: Run Common Tests - condition: succeededOrFailed() - workingDirectory: '$(repoPath)' - - template: dailyBuildCompliance.yml@ComplianceRepo parameters: sourceScanPath: '$(repoPath)' diff --git a/README.md b/README.md index d30953d7d5b7..8febbd105671 100644 --- a/README.md +++ b/README.md @@ -143,7 +143,7 @@ For more information on how and why we built this dashboard, check out this [blo ## Discussions -[GitHub Discussions](https://docs.github.com/en/free-pro-team@latest/discussions/quickstart) is a feature to enable fluid and open discussions within the community +[GitHub Discussions](https://docs.github.com/discussions/quickstart) is a feature to enable fluid and open discussions within the community for topics that are not related to code, unlike issues. This is an experiment we are trying in our repositories to see if it helps move discussions out of issues so that issues remain actionable by the team or members of the community.