Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting fails for using module <relative-path> #191

Open
chriskuech opened this issue Dec 7, 2019 · 3 comments
Open

Syntax highlighting fails for using module <relative-path> #191

chriskuech opened this issue Dec 7, 2019 · 3 comments

Comments

@chriskuech
Copy link

System Details

Can provide if necessary

Issue Description

Syntax highlighting does not work for relative path modules with the using module syntax.

Expected Behaviour

Syntax highlighting like this (ignore the warning)
image

Actual Behaviour

The statement is white.
image

Attached Logs

N/A

@msftrncs
Copy link
Contributor

msftrncs commented Dec 7, 2019

Yes, the syntax is very limited (too conservative) for the using keyword. The \ causes the entire syntaxing to fail, as its not acceptable per the grammar. I haven't made any improvement in this area either, with my PR #155 or #156, though I have in some others such as comment based help arguments.

@chriskuech
Copy link
Author

The \ causes the entire syntaxing to fail, as its not acceptable per the grammar.

Ironic because due to a bug, \ is required for relative path imports.

@msftrncs
Copy link
Contributor

msftrncs commented Dec 9, 2019

😄 , I don't think that is a bug, I think it is by-design as a defense in depth measure, but definitely ironic.

I might try to look in to improving the 'using' keyword's syntaxing logic. I've done some already for the namespace portion in my PR's, but not for module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants