Improvements to Comment Based Help Keywords #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
This PR improves the scoping of comment based help keywords, specifically fixing the lack of highlighting for the keywords that do not accept arguments when used on single-line comment lines.
This required an optimization to the single-line comment (
commentLine
), and tweaks to thecommentEmbeddedDocs
matches. By utilizing a^|\G
pattern, it can be prevented that extra#
be still permitted to match, which PowerShell does not permit. I also organized the keywords on their prospective matches alphabetically. On the match for keywords with arguments, I opened up the argument capture to all the available text, as there seems to be no additional rules that limit what PowerShell will accept.There are no tests that cover this particular condition, since the testing engine uses single-line comments to hide the test expressions.
commentBlock
tests have not changed.I am sure that #134 has not been reintroduced.