babel 7 types are incorrect

[43081j]

I've been doing a few small PRs in babel this week (babel/babel#8627, babel/babel#8628 and babel/babel#8629) to fix or introduce their now bundled TypeScript declarations.

I noticed a few small but breaking changes between the definitelytyped types and the official babel types for Babel 7. Figured I would raise them here for you as its possible the mismatch could mean we're missing null checks etc.

By running the analyzer build against the new types, I saw these:

• Only ObjectProperty has a value, ObjectMethod does not (babel-types source, example of our use)
• ArrayExpression introduces null as a member (babel-types source, example of our use)
• ExportNamedDeclaration has an optional declaration now (babel-types source, example of our use)

I'm not sure if you guys think its important as tests pass and what not. But it means since upgrading to babel 7, we're building against incorrect types here and not handling null values in a bunch of places.

If you think its a good idea to move to babel's built in types (you cannot mix and match them with the DT types, its one or the other across all babel packages), I'm happy to have a stab at it with the analyzer at least to see how it goes at some point.

cc @rictic

[rictic]

These all look like legit bugs, we should definitely upgrade

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!