Distinguish PR from branch builds in Tachometer checks #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
force-pushed
the
tach-pr-vs-branch
branch
6 times, most recently
from
754a399
to
1039fcf
Compare
aomarks
force-pushed
the
tach-pr-vs-branch
branch
from
1039fcf
to
a110940
Compare
aomarks
changed the title
aomarks
changed the title
rictic
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920
Previously, only the branch build was correctly appearing as a GitHub check, and the PR build was lost. That's because GitHub expects you to attach your checks to the same feature branch commit, not the automatically-generated merge commit, for both the branch and PR builds. We distinguish them by using a different title for the check.
Note in the screenshot below (or in the checks tab on this PR) that there are now two entries under Tachometer, one for the branch, one for the PR.