Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .ipynb submissions of examples somehow? #638

Closed
StanczakDominik opened this issue Jun 8, 2019 · 3 comments
Closed

Allow .ipynb submissions of examples somehow? #638

StanczakDominik opened this issue Jun 8, 2019 · 3 comments
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org
Milestone

Comments

@StanczakDominik
Copy link
Member

This came up during PlasmaPy/PlasmaPy-Tutorials#16 and a bit during PlasmaPy/PlasmaPy-Tutorials#17. Basically, working with the sphinx-gallery .py file format is more painful than working with notebooks, and I think we need to do everything we can to ease the example submission process.

There are a few ways I see that we could take here:

  • https://github.com/Chilipp/sphinx-nbexamples allows building examples from notebooks, but doesn't ease the fact that they're absolute pain to version control and review
  • https://nbsphinx.readthedocs.io/en/0.4.2/ is another way of doing the same
  • have a script that converts notebooks to .py once the PR is done, use it before merging example-adding PR - doesn't help with review, though that can be bypassed by simply pushing simple changes to notebooks instead of doing reviews (more or less limits example review to maintainers)
  • maybe even have a bot that does that to every commit adding a new file to examples

Opinions, gentlefolks? 😃

Other things I have stumbled upon while searching:

@StanczakDominik
Copy link
Member Author

also tagging @jhillairet for this discussion based on PlasmaPy/PlasmaPy-Tutorials#16 :

Indeed dealing with notebook in github with plain text is not easy. An inconvenient of notebooks is that they rapidly increase the repository size. On scikit-rf, the good practice is to pull "empty" notebooks, for this reason of size. Then the html documentation is built with sphinx from the notebooks.

That's an interesting idea, I'll have to look into that...

@namurphy namurphy added the docs PlasmaPy Docs at http://docs.plasmapy.org label Jun 11, 2019
@StanczakDominik StanczakDominik added this to the v0.3.0 milestone Jun 11, 2019
@StanczakDominik
Copy link
Member Author

scipy/scipy#5233 people have already had this discussion, it seems.

@StanczakDominik
Copy link
Member Author

This got done in #792.

Documentation Development automation moved this from Backlog to Closed / Cancelled Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org
Projects
Documentation Development
  
Closed / Cancelled
Development

No branches or pull requests

2 participants