Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Axios Error - Twitch Component Won't Execute Due to Error #4565

Closed
clarkio opened this issue Oct 23, 2022 · 18 comments · Fixed by #4576
Closed

[BUG] Axios Error - Twitch Component Won't Execute Due to Error #4565

clarkio opened this issue Oct 23, 2022 · 18 comments · Fixed by #4576
Assignees
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@clarkio
Copy link

clarkio commented Oct 23, 2022

Describe the bug
Using any of the Twitch components results in the action failing due to an error with Axios. After further investigation of the error I believe it's due to a recent change to the axios package which is noted in this issue in the Axios repo: axios/axios#5142. This seems to require some changes to what's provided in the configuration object to the axios package - specifically the paramsSerializer option. This option requires a new key called encode.

AxiosError
options must be an object

DETAILS
    at Object.assertOptions 

Note: see attached screen shot for error shown in my workflow

To Reproduce
Steps to reproduce the behavior:

  1. Add any Twitch component to a workflow
  2. Fill in all necessary fields for the Twitch component you chose
  3. Test the action using the Twitch component
  4. See the error

Expected behavior
Twitch actions to execute requests and return a result

Screenshots
image

Desktop (please complete the following information):

  • Browser: Brave
  • Version: Happy to share this but version of what? My browser? If so it's 1.44.112

Additional context
Axios seems to have made an update that's a breaking change based on this issue in their repo:

I believe this function in the pipedream Twitch component code needs to be updated:

_getParamsSerializer() {

This issue for the Axios docs covers what I believe needs to change: axios/axios-docs#90

Before:

paramsSerializer: function (params) {
    return Qs.stringify(params, {arrayFormat: 'brackets'})
},

After:

paramsSerializer: {
    encode: function(params) {
        return Qs.stringify(params, {arrayFormat: 'brackets'})
    }
},
@clarkio clarkio added the bug Something isn't working label Oct 23, 2022
@dilanmadusankaathukorala

Hi @clarkio, Thank you for reporting this issue, I am able to recreate it we will prioritize this to be fixed. Please follow this ticket for updates.

@DilanAthukorala DilanAthukorala added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Oct 24, 2022
@dannyroosevelt
Copy link
Collaborator

Thank you so much for the detailed report and breakdown, @clarkio! FYI since it looks like you were in the component code, we're happy to review a PR if you're interested in implementing the fix yourself, otherwise our team will take a look soon.

@lcaresia lcaresia self-assigned this Oct 24, 2022
@lcaresia lcaresia moved this from Prioritized to Doing in Component (Source and Action) Backlog Oct 24, 2022
@lcaresia lcaresia moved this from Doing to Ready for PR review in Component (Source and Action) Backlog Oct 25, 2022
@vellames vellames moved this from Ready for PR review to In Review in Component (Source and Action) Backlog Oct 25, 2022
@clarkio
Copy link
Author

clarkio commented Oct 25, 2022

@dannyroosevelt thanks and yea I'd be happy to but I see there is a PR open which I'm also happy to see 👍

@vellames vellames moved this from In Review to Ready for QA in Component (Source and Action) Backlog Oct 25, 2022
@dannyroosevelt
Copy link
Collaborator

Oops looks like we jumped the gun on it... but it's in the QA queue, so it should be fixed soon!

@clarkio
Copy link
Author

clarkio commented Oct 25, 2022

No worries. Glad to see it's moving along quickly and will be resolved

@ghost ghost moved this from Ready for QA to In QA in Component (Source and Action) Backlog Oct 25, 2022
@ghost ghost self-assigned this Oct 25, 2022
@ghost
Copy link

ghost commented Oct 25, 2022

@clarkio TestPassed
image

@ghost ghost moved this from In QA to Ready for release in Component (Source and Action) Backlog Oct 25, 2022
Component (Source and Action) Backlog automation moved this from Ready for release to Done Oct 26, 2022
@clarkio
Copy link
Author

clarkio commented Oct 27, 2022

This is great to see. Does it mean it's been published to the platform now as well? @Hassan-Abbas-SQA @lcaresia @dannyroosevelt

@lcaresia
Copy link
Collaborator

@clarkio Yes, it's published!

@clarkio
Copy link
Author

clarkio commented Oct 27, 2022

@lcaresia great to hear. Is there anything I need to do in my workflows to get it updated? I noticed the error still showing up when I tried earlier.

@lcaresia
Copy link
Collaborator

@lcaresia great to hear. Is there anything I need to do in my workflows to get it updated? I noticed the error still showing up when I tried earlier.

Yes, you need to remove the action and create again!

If you still having the problem call me on Slack and I will help you ☺️

@dannyroosevelt
Copy link
Collaborator

@clarkio you actually don't need to remove the action from your workflow -- you should see a red button at the top right of the Twitch step that says "Update".

@clarkio
Copy link
Author

clarkio commented Oct 27, 2022

@dannyroosevelt oh whew ok that sounds much better. However I did just manually update by removing some steps and re-adding them and it's working now. I'll use what you suggested @dannyroosevelt to update other workflows using this component.

@clarkio
Copy link
Author

clarkio commented Oct 27, 2022

@dannyroosevelt I'm not seeing that option in my workflows. Here is an example:
image

@dannyroosevelt
Copy link
Collaborator

Hey @clarkio that's strange. We aren't able to reproduce that issue. Can you try refreshing the page? If you still don't seen a prompt to Update the action, can you visit the settings for that workflow and enable the toggle to Share with Support, then paste the workflow URL so I can check it out?

@dannyroosevelt
Copy link
Collaborator

Actually, we were able to reproduce the error and we're looking into it. In the meantime if you want to get the action working asap, you can definitely remove that step and add it again.

@dannyroosevelt
Copy link
Collaborator

FYI we've identified the issue and confirmed it's not related to this Twitch update. We are tracking the issue re: not getting prompted to update existing actions here.

@dannyroosevelt
Copy link
Collaborator

FYI @clarkio this should be fixed -- you should now be able to update actions normally
Screenshot by Dropbox Capture

@clarkio
Copy link
Author

clarkio commented Oct 29, 2022

Awesome and thanks for sharing the update 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging a pull request may close this issue.

5 participants