Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add an option to show all videos from all playlists #66

Closed
3 tasks done
toby63 opened this issue Dec 16, 2023 · 9 comments
Closed
3 tasks done

Comments

@toby63
Copy link

toby63 commented Dec 16, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

There are multiple problems with the New playlists:

  1. You can't see all videos at once.
  2. You can't search for videos.
  3. You can't really sort videos intuitively
  4. You can't see if a video was already added (Update add video ot playlist prompt to show presence count when adding one video FreeTubeApp/FreeTube#4561 fixes this partly, but in the add menu)

Proposed Solution

Having an "All" Playlist can be the first way to solve this.

It would:

  1. show all videos that were added to any list
  2. maybe make it easier to search for specific videos, as it could be used as the only search source.
  3. it could be the menu to sort videos, as it includes all videos.
  4. make it easier to connect it with an indicator, such as the already existing star symbole.

Alternatives Considered

Issue Labels

improvement to existing feature

Additional Information

No response

@toby63

This comment was marked as outdated.

@toby63 toby63 closed this as completed Jan 27, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

This comment was marked as off-topic.

@toby63

This comment was marked as resolved.

@toby63 toby63 reopened this Feb 3, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

This comment was marked as duplicate.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

You can't see if a video was already added (Update add video ot playlist prompt to show presence count when adding one video FreeTubeApp#4561 fixes this partly, but in the add menu)

As playlists are allowed to contain the same video multiple times, this would just have to be a visual indicator, not a toggle button like the old favorites.

Secondly as you can now create as many playlists as you want, I'm not sure how much benefit you would get from an icon that tells you it is added to a playlist, because you have no idea which one.

While an all playlist does sound cool, a playlist that will inevitably be gigantic, will cause significant performance problems. See FreeTubeApp#4578 and FreeTubeApp#4597 for more information (TL;DR freezing for 14 seconds, on decently powerful hardware, on the watch page and any time the video changes while you are in that playlist).

Therefore, anyone wanting to implement the all list, should definitely wait until there are workarounds in place for gigantic playlists, to avoid them causing performance problems (no that linked pull request doesn't solve it, solving it will require reworking the lazy loading system, which is a bigger change).

There is a difference between a user creating a gigantic playlist and it lagging versus FreeTube auto-generating that gigantic playlist for you. If FreeTube does it, everyone would have the reasonable expectation that it should work well, so the all list should definitely wait.

@toby63
Copy link
Author

toby63 commented Feb 5, 2024

Secondly as you can now create as many playlists as you want, I'm not sure how much benefit you would get from an icon that tells you it is added to a playlist, because you have no idea which one.

@absidue
But you would know that you already have marked the video as favorite.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

Note to self: Migrating this and the other issues later. The most important ones have already been migrated over. You dont have to take any action so dont migrate them yourself :)

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

After internal discussion we decided to not migrate this over.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@toby63
Copy link
Author

toby63 commented May 14, 2024

After internal discussion we decided to not migrate this over.

Well I of course have to accept your decision, but even if you never want to implement this (which I think is 1. too early to say and 2. a big mistake (because of the multiple things that this could "solve"), it would be better to migrate this, so that people who want this feature can find this issue and see that you don't want to implement this, instead of opening new issues etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants