Fix errors in the dialog to override a report #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varCepheid
added
bug
|
This replaces PR #1514, which I accidentally merged handle-network-errors into. It has all the same changes I made. |
|
@varCepheid Can you add screenshots and testing instructions to this PR (in the description)? |
|
I think they're probably in #1514 because that was the original PR. I'll move them in here when I get the chance. |
varCepheid
added
the
priority
|
I added some testing instructions in the PR description. Does that help? I checked that the changes I made did what I want them to using the deploy preview. |
varCepheid
removed
the
priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1507
closes #1508
The current issues are that a) if the same user uploads a new report for the same team in the same match, it automatically overrides the old report; and b) there is no dialog to stop an accidental deletion of a report. In these changes, there are now dialogs for both of these situations.