Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v0.16.0 #69

Closed
mandrean opened this issue Aug 28, 2019 · 8 comments
Closed

Publish v0.16.0 #69

mandrean opened this issue Aug 28, 2019 · 8 comments

Comments

@mandrean
Copy link

mandrean commented Aug 28, 2019

Hi,

Would be awesome if you could publish a v0.16.0 of Strum to https://crates.io/crates/strum, as the latest version there is v0.15.0 from March, which for example doesn't have EnumVariantNames (#56)

Right now I have to do this to get EnumVariantNames in my project:

[dependencies]
strum = { git = "https://github.com/Peternator7/strum", rev = "efed58502a40ac101691068bbc6c20a0b351f3fd" }
strum_macros = { git = "https://github.com/Peternator7/strum", rev = "efed58502a40ac101691068bbc6c20a0b351f3fd" }

(Also would be nice with tags in Github that corresponds to the releases on Crates.io.)

Thanks!

@mandrean
Copy link
Author

mandrean commented Sep 2, 2019

@Peternator7

image

Actually I'm a bit blocked now in one of my own projejcts! What do you think, could you help a brother out and publish v0.16.0? 😄

@ahmed-masud
Copy link

Until he's published it, my suggestion would be to pull it in and use crates.io-patch

@mandrean
Copy link
Author

mandrean commented Sep 3, 2019

@ahmed-masud Building locally is fine with git + rev. I've also gotten [replace] and [patch.crates-io] working locally (separately)

But are you sure that one can publish a crate to Crates.io if the dependency is a replace or patch pointing at a git branch or revision?

I just couldn't get publishing working. I've tried all kinds of permutations, like:

[dependencies]
...
strum = "0.15.0"
strum_macros = "0.15.0"
url = "2.1.0"

[replace]
"strum:0.16.0" = { git = "https://github.com/Peternator7/strum", branch = "refactor" }
"strum_macros:0.15.0" = { git = "https://github.com/Peternator7/strum", branch = "refactor" }

and

[dependencies]
...
strum = "0.15.0"
strum_macros = "0.15.0"

[patch.crates-io]
"strum" = { git = "https://github.com/Peternator7/strum", branch = "refactor" }
"strum_macros" = { git = "https://github.com/Peternator7/strum", branch = "refactor" }

@Peternator7
Copy link
Owner

Peternator7 commented Sep 3, 2019 via email

@mandrean
Copy link
Author

mandrean commented Sep 3, 2019

Awesome 😄 Enjoy your honeymoon @Peternator7

@killercup
Copy link
Contributor

Enjoy your honeymoon!

(Found this issue when I wanted to ask for a new release, too. Also: If you need someone to help you maintain this crate, let me know!)

@Peternator7
Copy link
Owner

@mandrean , Version 0.16 is published :)

@mandrean
Copy link
Author

Awesome! Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants