Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proc-macro renames in Jan 2021 #122

Closed
Peternator7 opened this issue Oct 7, 2020 · 0 comments · Fixed by #149
Closed

Remove proc-macro renames in Jan 2021 #122

Peternator7 opened this issue Oct 7, 2020 · 0 comments · Fixed by #149

Comments

@Peternator7
Copy link
Owner

The Proc-Macro renames feature (in which you can enable the feature and the proc-macro becomes Strum<MacroName>) increases the surface area of things that need to be tested pretty substantially, but provides much less benefit in rust 2018 since macros can be scoped and imported just like any other feature.

Given Rust 2018 has been out for almost 2 years now, the first version of strum in 2021 will remove them and using import paths will be the only supported way to disambiguate proc-macros between crates.

See this wiki page for more context about the original feature. https://github.com/Peternator7/strum/wiki/Macro-Renames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant