Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero-sized files #79

Open
slifty opened this issue Feb 21, 2023 · 0 comments
Open

Handle zero-sized files #79

slifty opened this issue Feb 21, 2023 · 0 comments

Comments

@slifty
Copy link
Contributor

slifty commented Feb 21, 2023

Permanent currently has odd behavior with upload attempts for empty files, and it's ultimately rooted in this line: https://github.com/PermanentOrg/upload-service/blob/3617e443ec01e81087ea319cc38461ccd864f810/src/validators/validateCreateFileDestinationUrlParams.ts#L10

Basically: the permanent API awkwardly errors due to the above failed validation if an upload attempt of an empty file happens.

We should either:

  1. Change the backend behavior to support empty files! (I'm worried this was a passive decision / bug in the upload service implementation rather than a conscious UX choice)

  2. Detect zero size files at the sftp level and return an appropriate error code (currently what happens is an sdk error is thrown because of an unexpected response format)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant