Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core test fails if prefix has a space #4

Open
Tux opened this issue Apr 19, 2015 · 1 comment
Open

core test fails if prefix has a space #4

Tux opened this issue Apr 19, 2015 · 1 comment

Comments

@Tux
Copy link

Tux commented Apr 19, 2015

See https://rt.perl.org/Ticket/Display.html?id=124345

I don't think this is a Configure bug. I think it is wise to not test the installer before this test passes

$ ./Configure -de -Dprefix="/tmp/perl x" -Dusedevel -Duse64bitall
$ grep -w 'perl x' config.sh
config_args='-de -Dprefix=/tmp/perl x -Dusedevel -Duse64bitall'
config_arg2='-Dprefix=/tmp/perl x'
archlib='/tmp/perl x/lib/5.21.11/x86_64-linux'
bin='/tmp/perl x/bin'
installprefix='/tmp/perl x'
man1dir='/tmp/perl x/man/man1'
man3dir='/tmp/perl x/man/man3'
prefix='/tmp/perl x'
privlib='/tmp/perl x/lib/5.21.11'
scriptdir='/tmp/perl x x/bin'
sitearch='/tmp/perl x/lib/site_perl/5.21.11/x86_64-linux'
sitebin='/tmp/perl x/bin'
sitelib='/tmp/perl x/lib/site_perl/5.21.11'
siteman1dir='/tmp/perl x/man/man1'
siteman3dir='/tmp/perl x/man/man3'
siteprefix='/tmp/perl x'
sitescript='/tmp/perl x/bin'
$ make -j4
:
$ env TEST_JOBS=4 make test_harness
:
Test Summary Report
-------------------
../cpan/ExtUtils-Install/t/Installed.t                          (Wstat: 1792 Tests: 73 Failed: 7)
  Failed tests:  9, 56, 58, 60-61, 65-66
  Non-zero exit status: 7
$ cd t
$ ./perl -I../lib ../cpan/ExtUtils-Install/t/Installed.t
1..73
ok 1 - use ExtUtils::Installed;
ok 2 - _is_prefix() should match valid path prefix
ok 3 - ... should not match wrong prefix
ok 4 - _is_type() should be true for type of "all"
ok 5 - ... should find doc file in man1dir
ok 6 - ... but not prog file in man1dir
ok 7 - ... should find doc file in man3dir
ok 8 - ... but not prog file in man3dir
not ok 9 - ... should find prog file under /tmp/perl x
#   Failed test '... should find prog file under /tmp/perl x'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 60.
ok 10 - ... should not find doc file outside path
ok 11 - ... nor prog file outside path
:
ok 54 - files() should croak given bad modname
ok 55 - files() should croak given bad type
not ok 56 - ... should find doc file under given dir
#   Failed test '... should find doc file under given dir'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 267.
#          got: '3'
#     expected: '1'
ok 57 - ... checking file name
not ok 58 - ... should find all doc files with no dir
#   Failed test '... should find all doc files with no dir'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 273.
#          got: '3'
#     expected: '2'
ok 59 - ... should find no doc files given wrong dirs
not ok 60 - ... should find doc file in correct dir
#   Failed test '... should find doc file in correct dir'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 279.
#          got: '0'
#     expected: '1'
not ok 61 - ... checking file name
#   Failed test '... checking file name'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 280.
#                   undef
#     doesn't match '(?^:foobar[>\]]?$)'
ok 62 - ... should find all files with no type specified
ok 63 - directories() should return no dirs if no files found
ok 64 - ... should find all files files() would
not ok 65 - ... should find all files files() would, again
#   Failed test '... should find all files files() would, again'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 295.
#          got: '3'
#     expected: '4'
not ok 66 - ... should sort output
#   Failed test '... should sort output'
#   at ../cpan/ExtUtils-Install/t/Installed.t line 297.
#          got: '. /tmp/perl /tmp/perl /tmp/perl x'
#     expected: '. /tmp/perl /tmp/perl x'
ok 67 - directory_tree() should report intermediate dirs to those requested
ok 68 - validate() should croak when asked about uninstalled module
ok 69 - packlist() should croak when asked about uninstalled module
ok 70 - version() should croak when asked about uninstalled module
ok 71 - validate() should return results of packlist validate() call
ok 72 - packlist() should report installed mod packlist
ok 73 - version() should report installed mod version
# Looks like you failed 7 tests of 73.

[edited to fix formatting - ether]

demerphq added a commit that referenced this issue May 18, 2017
This is actually two issues. One is that we don't handle the
spaces properly, and the other is that our tests dont handle
when man1dir and man3dir are the same.
@toddr
Copy link
Contributor

toddr commented Sep 15, 2020

If I'm reading this right, the issue has been addressed by 143758b long ago and is working now. Can you confirm @Tux ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants