Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullish coalescing support #114

Closed
Alexsey opened this issue Jul 28, 2020 · 5 comments
Closed

Nullish coalescing support #114

Alexsey opened this issue Jul 28, 2020 · 5 comments

Comments

@Alexsey
Copy link
Contributor

Alexsey commented Jul 28, 2020 •
edited

It would be nice to have it. Rollup is already supporting it rollup/rollup#3548
@PepsRyuu
Copy link
Owner

Is it specifically the Acorn parser that's failing in the error logs? I assume just updating that will do the trick.

@PepsRyuu
Copy link
Owner

Installing a fresh project seems to work for me, can you confirm the version of Acorn that's installed in the node_modules directory? Can you try deleting the directory and package-lock.json and re-run npm install?

@Alexsey
Copy link
Contributor Author

Alexsey commented Jul 28, 2020

I've got 7.1.0. Then I've updated it to 7.3.1 and it worked! So yes, just bumping acorn works. Can I create a PR with the minimal version bump, so non-fresh installs of nollup can also got it work out of the box?

@PepsRyuu
Copy link
Owner

Go for it! :)

@Alexsey Alexsey mentioned this issue Jul 28, 2020
Merged
@Alexsey Alexsey closed this as completed Jul 28, 2020
@PepsRyuu
Copy link
Owner

Fix published in 0.13.0. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexsey @PepsRyuu