Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers are not collapsed when using Tabs.FlashList. #400

Open
Ucekay opened this issue May 5, 2024 · 14 comments
Open

Headers are not collapsed when using Tabs.FlashList. #400

Ucekay opened this issue May 5, 2024 · 14 comments

Comments

@Ucekay
Copy link

Ucekay commented May 5, 2024

(Written with machine translation)

Description

When using Tabs.FlashList (and Tabs.MasonryFlashList), the header does not change in any way and does not fold; with Tabs.FlatList and Tabs.ScrollView it works fine and the header folds.
In addition, when moving to Tabs.FlashList with the header collapsed in Tabs.FlatList, etc., the height of the Header is maintained, but if the FlashList is scrolled down, a blank space equal to the height of the Header is created.

Steps to reproduce

Fork this repository and run the example app

Video

2024-05-05.14.26.36.mov
@saulamsal
Copy link

+1 same issue.

@tomas1808
Copy link

Same!

@vbylen
Copy link

vbylen commented May 11, 2024

can confirm

@YahyaBagia
Copy link

+1 same issue

@NickKotte
Copy link

same. worked before i updated expo and maybe accidently updated this package

@tomas1808
Copy link

tomas1808 commented May 13, 2024

Fixed this by setting react-native-reanimated to exactly 3.8.1 👍

@vbylen
Copy link

vbylen commented May 14, 2024

@tomas1808 interesting, I tried this but didn't work. Is this version 7.0.1 of react-native-collapsible-tab-view?

@tomas1808
Copy link

@vbylen My exact configuration is:

  • "react-native-collapsible-tab-view": "^7.0.1"
  • "react-native-pager-view": "^6.2.3"
  • "react-native-reanimated": "3.8.1"

@saulamsal
Copy link

@tomas1808 what about react-native-gesture-handler?

@tomas1808
Copy link

@saulamsal "react-native-gesture-handler": "~2.14.0"

@Ucekay
Copy link
Author

Ucekay commented May 15, 2024

Fixed this by setting react-native-reanimated to exactly 3.8.1 👍

Thank you, @tomas1808 !
I am able to solve this by simply changing reaxt-native-reanimated to 3.8.1. Here are the versions of the packages.

  • "react-native-collapsible-tab-view": "^7.0.1"
  • "react-native-pager-view": "^6.3.0"
  • "react-native-gesture-handler": "^2.16.0"

I have a feeling that this problem is related to this issue that has been occurring since version 3.9.0 of react-native-reanimated.

@tomas1808
Copy link

tomas1808 commented May 15, 2024

@Ucekay Glad it worked for you! Not sure why not everyone is having the same success.

I'll use this moment to promote my own question in case anyone is feeling like giving back 🤣

@Ucekay Ucekay closed this as completed May 20, 2024
@YahyaBagia
Copy link

YahyaBagia commented May 20, 2024

This package used to work seamlessly with expo. However, after upgrading from expo SDK 50 to SDK 51, the following dependencies were updated:

  • react-native-reanimated: ~3.6.23.10.1
  • react-native-pager-view: 6.2.36.3.0
  • react-native-gesture-handler: 2.14.02.16.1

Since expo includes specific versions of these packages with each release, manually changing the versions isn't feasible.

I recommend keeping this issue open until it is resolved and the package is compatible with the latest expo SDK 51 (51.0.8 as of May 20th 2024).

@Ucekay Ucekay reopened this May 20, 2024
@chen8520
Copy link

@Ucekay I performed the same operation, but there will be version compatibility issues
image
截屏2024-05-21 09 59 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants