Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmldom is renamed to @xmldom/xmldom #21

Open
melnikaite opened this issue Aug 20, 2021 · 1 comment
Open

xmldom is renamed to @xmldom/xmldom #21

melnikaite opened this issue Aug 20, 2021 · 1 comment

Comments

@melnikaite
Copy link

xmldom is renamed to @xmldom/xmldom because of security issue https://npmjs.com/advisories/1769
Details are here xmldom/xmldom#271
@karfau
Copy link

karfau commented Dec 25, 2021 •
edited

I'm one of the maintainers of xmldom, thx for already filing this issue.
I'm happy to file an upgrade PR and fix any regressions that we find along the way if it is wanted (#18 was not even landed since March).

Just reply or ping me.

karfau added a commit to karfau/xml-core that referenced this issue Dec 26, 2021
@karfau
Update xmldom dependency
b2f867f 
Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- I used node 12 to run `yarn`.
- It already executed some checks, there is a warning, but it didn't fail
- fixes PeculiarVentures#21
@karfau karfau mentioned this issue Dec 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update xmldom dependency karfau/xml-core
2 participants
@karfau @melnikaite