Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PCH imprecise number functions #1866

Open
acicovic opened this issue Sep 18, 2023 · 0 comments
Open

Simplify PCH imprecise number functions #1866

acicovic opened this issue Sep 18, 2023 · 0 comments
Labels
Type: Maintenance Type: Refactoring Items that result directly or indirectly in refactoring
Milestone
Future Milestone

Comments

@acicovic
Copy link
Collaborator

acicovic commented Sep 18, 2023 •
edited

Is your feature request related to a problem?

We've got a PHP and TS imprecise number function that we use for the PCH. These were ported from the respective Parse.ly dash code in order to have identical results between dash and PCH.

Describe the solution you'd like

Check the discussion here and see if we can have identical results to dash with simpler versions of the functions.

Describe alternatives you've considered

Do nothing.
@acicovic acicovic added this to the Future Milestone milestone Sep 18, 2023
@acicovic acicovic added the Type: Refactoring Items that result directly or indirectly in refactoring label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Type: Refactoring Items that result directly or indirectly in refactoring
Projects
None yet
Milestone
Future Milestone
Development

No branches or pull requests
1 participant
@acicovic