Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize some options with their UI label #1242

Open
acicovic opened this issue Dec 9, 2022 · 1 comment
Open

Harmonize some options with their UI label #1242

acicovic opened this issue Dec 9, 2022 · 1 comment

Comments

@acicovic
Copy link
Collaborator

acicovic commented Dec 9, 2022

Is your feature request related to a problem?

As time passes, our terminologies might change, and with it our settings page gets updates. Examples of this are "API Key" that has been renamed to "Site ID" and "Track as Page" that has been renamed to "Track as Non-Post".

In many of those cases, we quickly update the UI but not the underlying options. For example, the value of "Track as Non-Post" is still page. In large part, this is because renaming the options themselves can have undesired effects if not handled properly. However, this leads to out-of-sync code that can become harder to understand as time goes by.

Describe the solution you'd like

Find the affected options and give them a more representative name, making sure that:

  • Nothing breaks.
  • Upgrade path works.
  • Downgrade path works.

Related PRs/issues:

@GaryJones
Copy link
Contributor

Renaming public methods and property names could be done on a major semantic versioning release.

@danielabloch danielabloch modified the milestones: Unassigned, 3.8.0 Jan 26, 2023
@mjangda mjangda modified the milestones: 3.8.0, Unassigned Feb 27, 2023
@acicovic acicovic modified the milestones: Future Milestone, 4.0.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants