Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableTraps() vs revoke() #37

Open
warpech opened this issue Jun 6, 2019 · 0 comments
Open

disableTraps() vs revoke() #37

warpech opened this issue Jun 6, 2019 · 0 comments

Comments

@warpech
Copy link
Contributor

warpech commented Jun 6, 2019

It is not clear to me what's the point of having the two public methods disableTraps() and revoke(). In the tests, they are always tested separately.

In real life usage, shouldn't I use both of them?

If it was up to me, I would merge these methods into one. But maybe I am missing something.

I checked if they are used in Palindrom and they are not.

cc @alshakero, @tomalec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant