Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Some checks are needed between fakeroot content and pre|post install stages #26

Open
M0Rf30 opened this issue Mar 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@M0Rf30
Copy link
Contributor

M0Rf30 commented Mar 30, 2022

Is your feature request related to a problem? Please describe.
Conceptually when installing a file in the fakeroot (pkgdir), it must not be possible to delete it in the functions:

  • postinst()
  • preinst()

The motivation is subtle but damn simple.
A file within the fakeroot (pkgdir, placed by the package function) it's considered as the final target package content (the package it's the owner of the fakeroot content, in other words).

When you remove or create an ephemeral or generated config file or something else similar (in postinst, for example), this should be checked against the fakeroot content.

This avoid bad practices and strage warnings (something that sounds approximately like: the file named x has no owners throughrough the packageset)

Describe the solution you'd like
Compare and check for same files path between fakeroot and pos|pre install stages. Something fuzzy? Idk
Exit with failure and show an informative message
Would be nice to have a --force flag in case you just need it (you know what are you doing)

@M0Rf30 M0Rf30 added the enhancement New feature or request label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant