Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Generated Files #93

Open
lishaduck opened this issue Jun 21, 2023 · 2 comments
Open

Commit Generated Files #93

lishaduck opened this issue Jun 21, 2023 · 2 comments
Assignees
@lishaduck
Labels
dart Regards Dart code enhancement New feature or request github_actions Regards GitHub Actions code good-first-issue Good for newcomers

Comments

@lishaduck
Copy link
Member

lishaduck commented Jun 21, 2023 •
edited

Per rrousselGit/riverpod#2631, it seems like that should drastically speed up CI.
@lishaduck lishaduck added enhancement New feature or request good-first-issue Good for newcomers github_actions Regards GitHub Actions code dart Regards Dart code labels Jun 21, 2023
@lishaduck lishaduck self-assigned this Jun 21, 2023
@lishaduck lishaduck mentioned this issue Jun 23, 2023
Closed
@lishaduck
Copy link
Member Author

lishaduck commented Jun 24, 2023 •
edited

And it might not. build_verify looks like it'll be slow. And delete the cache. So...even slower locally. I think we'll close this, we can revisit it later. I've figured out the flake, and that would be the only other reason I can think of to commit them.

@lishaduck lishaduck closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2023
@lishaduck
Copy link
Member Author

In retrospect, I'm reopening this. It bothers me that codegen must be re-run after checking out a branch. Whenever I switch between two branches or rebase or whatnot, I'm in an inconsistent state.

@lishaduck lishaduck reopened this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lishaduck lishaduck

Labels
dart Regards Dart code enhancement New feature or request github_actions Regards GitHub Actions code good-first-issue Good for newcomers
Projects
App
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lishaduck