Update ReferenceHelper.php #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkBaker
reviewed
Feb 27, 2021
| @@ -608,7 +608,12 @@ public function insertNewBefore($pBefore, $pNumCols, $pNumRows, Worksheet $pShee | |||
| // Update workbook: define names | |||
| if (count($pSheet->getParent()->getDefinedNames()) > 0) { | |||
| foreach ($pSheet->getParent()->getDefinedNames() as $definedName) { | |||
| if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) { | |||
| $hash = null; | |||
| if ($definedName->getWorksheet()) { | |||
There was a problem hiding this comment.
Just for the sake of readability, can you do an explicit comparison for not null)..
This is something that I've been doing in all the code that I've been working with recently, and it does make the if comparison a lot more explicit rather than relying on the loose typed truthiness/falsiness of PHP
ivanstan
commented
Mar 1, 2021
| @@ -608,7 +608,7 @@ public function insertNewBefore($pBefore, $pNumCols, $pNumRows, Worksheet $pShee | |||
| // Update workbook: define names | |||
| if (count($pSheet->getParent()->getDefinedNames()) > 0) { | |||
| foreach ($pSheet->getParent()->getDefinedNames() as $definedName) { | |||
| if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) { | |||
| if ($definedName->getWorksheet() !== null && $definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) { | |||
There was a problem hiding this comment.
@MarkBaker does this make sense?
I don't think updateCellReference should be called on a null worksheet
There was a problem hiding this comment.
Makes perfect sense. thanks for the quick update
MarkBaker
approved these changes
Mar 1, 2021
| @@ -608,7 +608,7 @@ public function insertNewBefore($pBefore, $pNumCols, $pNumRows, Worksheet $pShee | |||
| // Update workbook: define names | |||
| if (count($pSheet->getParent()->getDefinedNames()) > 0) { | |||
| foreach ($pSheet->getParent()->getDefinedNames() as $definedName) { | |||
| if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) { | |||
| if ($definedName->getWorksheet() !== null && $definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) { | |||
There was a problem hiding this comment.
Makes perfect sense. thanks for the quick update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Fixes issue #1872