Fix/sheets xlsx chart #1761
Merged
Fix/sheets xlsx chart #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Sheets XLSX charts use oneCellAnchor positioning and the data series do not have the *Cache elements with cached values.
Google Sheets XLSX charts use oneCellAnchor positioning and the data series do not have the *Cache elements with cached values. Because the reader had been assuming *Cache elements existed as children of strRef and numRef, errors about the node being deleted were thrown when reading Xlsx exported from Google Sheets.
|
Thank you for providing this resolution to one-cell-anchor charts, and the issue with cache elements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
When exporting Google Sheets as Xlsx, charts are positioned using oneCellAnchor which previously had not been implemented. In additional exported Xlsx files do not contain the *Cache element. Since *Chache elements had been assumed to be children of numRef and strRef elements, "Node has been deleted" errors were thrown when attempting to read an Xlsx exported from Google Sheets.