Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/chart axis titles #1760

Merged
merged 4 commits into from Jan 31, 2021
Merged

Conversation

hazybluedot
Copy link
Contributor

@hazybluedot hazybluedot commented Dec 20, 2020

…axisLabel or YaxisLabel

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

For some Xlsx files when only a horizontal axis title was given it would map to a YAxisTitle. The reader was treating varAx as a title for only the YAxisTitle, but at least for scatter charts in Excel 2019, varAx is used for both the horizontal and vertical axis labels. This fix uses the axPos element to determine axis position, bottom and top are mapped to XAxisLabel, while left and right are mapped to YAxisLabel.

@MarkBaker
Copy link
Member

Thank you for this resolution to problems with single-axis charts

@MarkBaker MarkBaker merged commit c82ff25 into PHPOffice:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants