Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Timeout in stream_select (get_lines()) #2018

Closed
wants to merge 1 commit into from

Conversation

romkoll
Copy link

@romkoll romkoll commented Mar 26, 2020

In stream_select must be used $this->Timeout, not $this->Timelimit

In stream_select must be used $this->Timeout, not $this->Timelimit
@Synchro
Copy link
Member

Synchro commented Mar 26, 2020

There is a mistake here, but it's in the subsequent debug output, not the stream_select call. Timeout is a timeout for initial connection and network outage, not the per-command timeout, which is what Timelimit is, so the code is correct but the debug output is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants