New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe it is better to make the default value as in the standard ('simple') for $style #11

Open

jetsam729 opened this issue Mar 7, 2021 · 0 comments

jetsam729 commented Mar 7, 2021

    protected function canonicalizeHeaders(array $headers, string $style = '**relaxed**'): string
...
    protected function canonicalizeBody(string $body, string $style = '**relaxed**', int $length = -1): string

https://tools.ietf.org/html/rfc6376#section-3.5
c= Message canonicalization (plain-text; OPTIONAL, default is "simple/simple").

Maybe it is better to make the default value as in the standard? -> $style = 'simple',

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment