{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":201833217,"defaultBranch":"develop","name":"PHPCSUtils","ownerLogin":"PHPCSStandards","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-08-12T01:01:13.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/54010123?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716762841.0","currentOid":""},"activityList":{"items":[{"before":"6b9ea39f94168be929f57b84b65179ffeb62e153","after":null,"ref":"refs/heads/testutils/utilitymethodtestcase-parsefile-add-type-declarations","pushedAt":"2024-05-26T22:34:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"85846f22bdb9a707beaa032a77c5a7714b3ddf26","after":"3dcf4180d2381c4ebc885f8b04b66d4624140982","ref":"refs/heads/develop","pushedAt":"2024-05-26T22:34:00.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #610 from PHPCSStandards/testutils/utilitymethodtestcase-parsefile-add-type-declarations\n\nUtilityMethodTestCase::parseFile(): add missing type declarations","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317961079\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/610\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/610/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/610\">#610</a> from PHPCSStandards/testutils/utilitymethodte…"}},{"before":null,"after":"6b9ea39f94168be929f57b84b65179ffeb62e153","ref":"refs/heads/testutils/utilitymethodtestcase-parsefile-add-type-declarations","pushedAt":"2024-05-26T22:27:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"UtilityMethodTestCase::parseFile(): add missing type declarations","shortMessageHtmlLink":"UtilityMethodTestCase::parseFile(): add missing type declarations"}},{"before":"7e953e495d19900aeab6905f61b6b381b097adfb","after":null,"ref":"refs/heads/1.1.0/new-constants-class","pushedAt":"2024-05-26T22:26:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"8752e2b5250ad9fecde8faf9b5085d4af8d19ac3","after":"85846f22bdb9a707beaa032a77c5a7714b3ddf26","ref":"refs/heads/develop","pushedAt":"2024-05-26T22:26:39.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #562 from PHPCSStandards/1.1.0/new-constants-class\n\n✨ New PHPCSUtils\\Utils\\Constants class + associated token collection","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2153760624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/562/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/562\">#562</a> from PHPCSStandards/1.1.0/new-constants-class"}},{"before":"2657594935e72da3f7c15aa28a37d026c8f64165","after":"7e953e495d19900aeab6905f61b6b381b097adfb","ref":"refs/heads/1.1.0/new-constants-class","pushedAt":"2024-05-26T22:20:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":":sparkles: New `PHPCSUtils\\Utils\\Constants` class\n\n... to contain utilities methods for analysing constants declared using the `const` keyword.\n\nIn the future, the scope of the methods might be expanded to also covered constants declared using `define()`, but that's for later.\n\nInitially, the class comes with the following method:\n* `getProperties(File $phpcsFile, $stackPtr): array` to retrieve an array of information about a constant declaration, like the visibility, whether visibility was explicitly declared, whether the constant was declared as final, what the type is for the constant etc.\n\nIncludes extensive unit tests.","shortMessageHtmlLink":"✨ New <code>PHPCSUtils\\Utils\\Constants</code> class"}},{"before":"2b6d5564229e2e52d6c320ddadde3f2f1f6e1231","after":null,"ref":"refs/heads/utils/new-types-utility-class","pushedAt":"2024-05-23T20:34:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"b5ee7dc6c5b8b0ccf1217315694451701e06ff77","after":"8752e2b5250ad9fecde8faf9b5085d4af8d19ac3","ref":"refs/heads/develop","pushedAt":"2024-05-23T20:34:33.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #588 from PHPCSStandards/utils/new-types-utility-class\n\n:sparkles: New TypeString utility class","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2267788718\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/588\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/588/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/588\">#588</a> from PHPCSStandards/utils/new-types-utility-c…"}},{"before":"518d4125e681e6d075bb931beb7c8a9e4c7bde5b","after":"2b6d5564229e2e52d6c320ddadde3f2f1f6e1231","ref":"refs/heads/utils/new-types-utility-class","pushedAt":"2024-05-23T20:29:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":":sparkles: New TypeString utility class\n\n... to contain utilities methods for analysing typestrings as retrieved via the `getParameters()`/`getProperties()` methods.\n\nInitially, the class comes with the following methods:\n* `getKeywordTypes(): array` to retrieve an array of all currently supported type keywords.\n* `isKeyword(string $type): bool` to determine whether a type is a keyword type.\n* `normalizeCase(string $type): string` to normalize the case of keyword types to lowercase, while leaving the case of OO-based types alone.\n* `isSingular(string $typeString): bool` to determine if a type is a purely singular type.\n* `isNullable(string $typeString): bool` to determine if a type is a nullable type, either by it having the nullable type operator or by including `null` as part of a union or DNF type.\n* `isUnion(string $typeString): bool` to determine if a type is a union type.\n* `isIntersection(string $typeString): bool` to determine if a type is an intersection type.\n* `isDNF(string $typeString): bool` to determine if a type is an intersection type.\n* `toArray(string $typeString, bool $normalize = true): array` to split a type string to its individual types and optionally normalize the case of the types.\n* `toArrayUnique(string $typeString, bool $normalize = true): array` to split a type string to its unique individual types and optionally normalize the case of the types.\n* `filterKeywordTypes(array $types): array` to filter an array with individual types as found in a type string down to only the keyword types.\n* `filterOOTypes(array $types): array` to filter an array with individual types as found in a type string down to only the OO-name based types.\n\nNotes:\n* The methods in this class have limited or no handling for surrounding or internal whitespace as the type strings these methods are intended to be used with do not contain whitespace.\n* The behaviour with type strings not retrieved via the `getParameters()`/`getProperties()` methods, or non-type strings, is undefined.\n    This includes type strings found in docblocks. Those are not typically supported by the methods in this class.\n* The `is*()` methods will **not** check if the type string provided is **_valid_**, as doing so would inhibit what sniffs can flag.\n    The `is*()` methods will only look at the _form_ of the type string to determine if it _could_ be valid for a certain type.\n    Use the {@see \\PHPCSUtils\\Utils\\NamingConventions::isValidIdentifierName()} method if additional validity checks are needed on the individual \"types\" seen in a type string.\n     And, if needed, use token walking on the tokens of the type to determine whether a type string actually complies with the type rules as set by PHP.\n\nIncludes extensive unit tests.","shortMessageHtmlLink":"✨ New TypeString utility class"}},{"before":"a1e04b356edd5981f8a3f426921cff1def82e300","after":"b5ee7dc6c5b8b0ccf1217315694451701e06ff77","ref":"refs/heads/develop","pushedAt":"2024-05-23T20:17:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #593 from PHPCSStandards/utils/new-filepath-utility-class\n\n:sparkles: New `FilePath` utility class","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2290485608\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/593\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/593/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/593\">#593</a> from PHPCSStandards/utils/new-filepath-utilit…"}},{"before":"f87bfb425b090841a1368b837ace1fa3d5312304","after":null,"ref":"refs/heads/utils/new-filepath-utility-class","pushedAt":"2024-05-23T20:17:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"44629feecde6208f82e2d6eb03ae01c7fe1814c1","after":"f87bfb425b090841a1368b837ace1fa3d5312304","ref":"refs/heads/utils/new-filepath-utility-class","pushedAt":"2024-05-23T20:11:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":":sparkles: New `FilePath` class\n\n... with some utility functions for handling file paths.\n\nThe class initially contains the following utility methods:\n* `getName(File $phpcsFile): string` - Retrieve the normalized file name for the current file.\n* `isStdin(File $phpcsFile): bool` - Check whether the current file under scan comes from STDIN.\n* `normalizeAbsolutePath(string $path): string` - Normalize an absolute path to forward slashes and to include a trailing slash for directories.\n* `normalizeDirectorySeparators(string $path): string` - Normalize all directory separators to be a forward slash.\n* `trailingSlashIt(string $path): string` - Ensure that a directory path ends on a trailing slash.\n* `startsWith(string $haystack, string $needle): bool` - Check whether one file/directory path starts with another path.\n\nIncludes unit tests.","shortMessageHtmlLink":"✨ New <code>FilePath</code> class"}},{"before":"c16c199c2bf3c20da3b4116335691089919237ef","after":null,"ref":"refs/heads/objectdeclarations/new-getmethods-utility","pushedAt":"2024-05-23T11:17:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"d727caa32cd3362690f5606bdc997c158d2a5137","after":"a1e04b356edd5981f8a3f426921cff1def82e300","ref":"refs/heads/develop","pushedAt":"2024-05-23T11:17:33.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #592 from PHPCSStandards/objectdeclarations/new-getmethods-utility\n\n:sparkles: New ObjectDeclarations::getDeclared*() utility methods","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2288997692\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/592\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/592/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/592\">#592</a> from PHPCSStandards/objectdeclarations/new-ge…"}},{"before":"284714b32b6e4427c42fa64684538f2c949a9a4d","after":"c16c199c2bf3c20da3b4116335691089919237ef","ref":"refs/heads/objectdeclarations/new-getmethods-utility","pushedAt":"2024-05-23T08:52:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":":sparkles: New ObjectDeclarations::getDeclared*() utility methods\n\nThis commit adds a new set of utility methods to the `ObjectDeclarations` class:\n* `getDeclaredConstants(File $phpcsFile, int $stackPtr): array`\n* `getDeclaredEnumCases(File $phpcsFile, int $stackPtr): array`\n* `getDeclaredProperties(File $phpcsFile, int $stackPtr): array`\n* `getDeclaredMethods(File $phpcsFile, int $stackPtr): array`\n* (`private`) `analyzeOOStructure(File $phpcsFile, int $stackPtr): array`\n\nThese methods allow for retrieving an array with the names of all constants, enum cases, properties and methods as the keys and the stack pointer to the relevant `T_CONST`, `T_ENUM_CASE`, `T_VARIABLE` or `T_FUNCTION` token as the value.\n\nAs these methods all used the same `analyzeOOStructure()` method under the hood and the results of that method are cached, the method are highly optimized for performance.\n\nIf a sniff needs to search for a named constant/enum case/property/method in an OO structure, in most cases, these methods should be the recommended way for finding the declaration, instead of the sniff attempting to do this itself.\n\nIncludes extensive unit tests.","shortMessageHtmlLink":"✨ New ObjectDeclarations::getDeclared*() utility methods"}},{"before":"882951130e9e759cf68a323eccdf720323fc4834","after":"2657594935e72da3f7c15aa28a37d026c8f64165","ref":"refs/heads/1.1.0/new-constants-class","pushedAt":"2024-05-23T08:44:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Constants: reorder some tests","shortMessageHtmlLink":"Constants: reorder some tests"}},{"before":"cf7421acdcbab77f6833fb75376761c2a865bb11","after":null,"ref":"refs/heads/feature/getversiontest-update-phpcs-version","pushedAt":"2024-05-23T07:27:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"c51f0a4ed45793027b00026dea2544cdc0a1380c","after":"d727caa32cd3362690f5606bdc997c158d2a5137","ref":"refs/heads/develop","pushedAt":"2024-05-23T07:27:47.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #609 from PHPCSStandards/feature/getversiontest-update-phpcs-version\n\nGetVersionTest: update for release of PHPCS 3.10.1","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2311870805\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/609\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/609/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/609\">#609</a> from PHPCSStandards/feature/getversiontest-up…"}},{"before":null,"after":"cf7421acdcbab77f6833fb75376761c2a865bb11","ref":"refs/heads/feature/getversiontest-update-phpcs-version","pushedAt":"2024-05-23T03:41:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"GetVersionTest: update for release of PHPCS 3.10.1","shortMessageHtmlLink":"GetVersionTest: update for release of PHPCS 3.10.1"}},{"before":"24a3c0d32dfc4a1dd5da3a86451656f5517d93ae","after":null,"ref":"refs/heads/feature/getversiontest-update-phpcs-version","pushedAt":"2024-05-21T08:30:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"35bad875d088477c6f4773b483488e42e78f6c64","after":"c51f0a4ed45793027b00026dea2544cdc0a1380c","ref":"refs/heads/develop","pushedAt":"2024-05-21T08:30:40.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #608 from PHPCSStandards/feature/getversiontest-update-phpcs-version\n\nGetVersionTest: update for release of PHPCS 3.10.0","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2307206708\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/608\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/608/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/608\">#608</a> from PHPCSStandards/feature/getversiontest-up…"}},{"before":null,"after":"24a3c0d32dfc4a1dd5da3a86451656f5517d93ae","ref":"refs/heads/feature/getversiontest-update-phpcs-version","pushedAt":"2024-05-21T03:41:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"GetVersionTest: update for release of PHPCS 3.10.0","shortMessageHtmlLink":"GetVersionTest: update for release of PHPCS 3.10.0"}},{"before":"33541ff21a8181e93a7112242e1aba5286325166","after":null,"ref":"refs/heads/feature/add-more-defensive-coding-typeerrors","pushedAt":"2024-05-20T19:13:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"a66c8d4bb42ad5b454a92fd1fbd00780f42ff823","after":"35bad875d088477c6f4773b483488e42e78f6c64","ref":"refs/heads/develop","pushedAt":"2024-05-20T19:13:24.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #600 from PHPCSStandards/feature/add-more-defensive-coding-typeerrors\n\nAdd more defensive coding / improve type checking","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2292467321\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/600\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/600/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/600\">#600</a> from PHPCSStandards/feature/add-more-defensiv…"}},{"before":"c15cf0696b8cd54b372f962b2f994e921191b6bd","after":"33541ff21a8181e93a7112242e1aba5286325166","ref":"refs/heads/feature/add-more-defensive-coding-typeerrors","pushedAt":"2024-05-20T19:00:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Add more defensive coding / improve type checking\n\nAdd more defensive coding against incorrect stack pointers being passed.\n\nIt is common to pass the result of a call to `File::findPrevious()` or `File::findNext()` to functions expecting a stack pointer, but these `File` functions can return `false`, which would be juggled to `0` when used in the typical `isset($tokens[$stackPtr])` checks.\nThis would then lead to that check passing, while the value should have been rejected, as the method may now try to act on a completely different token than intended (and more defensive coding should have been added to the originating sniff).\n\nAdding a preliminary check to make sure the received parameter is an integer prevents this problem and should surface any such bugs in sniffs using the updated PHPCSUtils methods.\n\nIncludes tests.","shortMessageHtmlLink":"Add more defensive coding / improve type checking"}},{"before":"da71d5a04cc2519f2133e48f3a7c17418fd6685d","after":"c15cf0696b8cd54b372f962b2f994e921191b6bd","ref":"refs/heads/feature/add-more-defensive-coding-typeerrors","pushedAt":"2024-05-20T18:55:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Add more defensive coding / improve type checking\n\nAdd more defensive coding against incorrect stack pointers being passed.\n\nIt is common to pass the result of a call to `File::findPrevious()` or `File::findNext()` to functions expecting a stack pointer, but these `File` functions can return `false`, which would be juggled to `0` when used in the typical `isset($tokens[$stackPtr])` checks.\nThis would then lead to that check passing, while the value should have been rejected, as the method may now try to act on a completely different token than intended (and more defensive coding should have been added to the originating sniff).\n\nAdding a preliminary check to make sure the received parameter is an integer prevents this problem and should surface any such bugs in sniffs using the updated PHPCSUtils methods.\n\nIncludes tests.","shortMessageHtmlLink":"Add more defensive coding / improve type checking"}},{"before":"1c9176d26d45495f1ab764325b267778739a1175","after":null,"ref":"refs/heads/feature/start-using-the-new-exceptions","pushedAt":"2024-05-20T18:50:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"f2d828281934bea39bc9c8f7b7568007775515c2","after":"a66c8d4bb42ad5b454a92fd1fbd00780f42ff823","ref":"refs/heads/develop","pushedAt":"2024-05-20T18:50:51.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #599 from PHPCSStandards/feature/start-using-the-new-exceptions\n\nStart using the new exceptions","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2292458603\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHPCSUtils/issues/599\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHPCSUtils/pull/599/hovercard\" href=\"https://github.com/PHPCSStandards/PHPCSUtils/pull/599\">#599</a> from PHPCSStandards/feature/start-using-the-n…"}},{"before":"18fb7964944f4787bd7578a48512ac9514c2654b","after":"1c9176d26d45495f1ab764325b267778739a1175","ref":"refs/heads/feature/start-using-the-new-exceptions","pushedAt":"2024-05-20T18:28:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Only catch what should be caught\n\nThis changes the exceptions being caught in various `catch` statements to more specific ones.\n\nThis means that errors which should always have been thrown, will now throw and only the potentially expected (and acceptable) exceptions will now be caught.\n\nNote:\n* For the `Namespaces::getDeclaredName()` method, the `catch` has not been changed (other than switching from the PHPCS native `RuntimeException` to the PHPCSUtils one).\n    The reason for this is that the method is explicitly documented as returning `false` for non-existent tokens.\n    While this behaviour is not in line with other methods in PHPCSUtils, changing the behaviour could be seen as a breaking change, so should be done in a major release.\n\nIncludes test for where the behaviour of the functions is now different.","shortMessageHtmlLink":"Only catch what should be caught"}},{"before":"5680552c379f868c996de9f5c41bfb17dc6ff434","after":"18fb7964944f4787bd7578a48512ac9514c2654b","ref":"refs/heads/feature/start-using-the-new-exceptions","pushedAt":"2024-05-20T18:26:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"[squash] Add tests for the changes in \"catch\" behaviour\n\n// Add to original commit message:\n\nIncludes test for where the behaviour of the functions is now different.","shortMessageHtmlLink":"[squash] Add tests for the changes in \"catch\" behaviour"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVFpJogA","startCursor":null,"endCursor":null}},"title":"Activity · PHPCSStandards/PHPCSUtils"}