Adding support for proxy class generation on container compilations #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2019 16:32
Solves: Pre-generate proxy classes PHP-DI#542
mnapoli
reviewed
Feb 16, 2019
mnapoli
reviewed
Feb 24, 2019
|
@bbaga I sent a pull request on your pull request 😄 : bbaga#1 The goal was to simplify the changes by removing the custom class that extends ProxyManager. What I did is I invoke the proxy factory instead, we just don't use the created instance. At least we don't deal with ProxyManager internals because I would rather avoid having to update it when new versions are published. If you merge bbaga#1 we can then merge this one and I can tag a release. |
|
@mnapoli makes sense, thank you for following up on this! PR merged on my side. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue where we would have to write custom workaround to pre-generate all proxy classes in our container and it isn't very pretty. Would be much nicer if this functionality would be provided out of the box.
This is my attempt generate the proxies when we build the container.
I wonder if it would be beneficial to put the proxy classes into the container file, like Symfony DI does it.
Issue: #542