Simplify conditions #630
Merged
Simplify conditions #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Oct 4, 2018
| } | ||
| $value = $parameter->isOptional() && ! $this->definitionResolver->isResolvable($value) | ||
| ? $this->getParameterDefaultValue($parameter, $method) | ||
| : $this->definitionResolver->resolve($value); |
There was a problem hiding this comment.
While the rest are great improvements I don't feel this one is more readable with the change, could you revert this?
|
Done, @mnapoli, I reversed the change in the file |
mnapoli
reviewed
Oct 7, 2018
| @@ -71,7 +71,6 @@ public function resolveParameters( | |||
|
|
|||
| // Nested definitions | |||
| if ($value instanceof Definition) { | |||
| // If the container cannot produce the entry, we can use the default parameter value | |||
There was a problem hiding this comment.
I just notice this removal: why remove the comment?
|
@mnapoli I removed the comments by mistake, now I revert the remove of comment |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to simplify conditions, either by applying an early return or apply ternary operations in
ifandelseconditions