Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerInterface should be registered to point to the wrapper container #582

Closed
mnapoli opened this issue Mar 12, 2018 · 1 comment
Closed

ContainerInterface should be registered to point to the wrapper container #582

mnapoli opened this issue Mar 12, 2018 · 1 comment
Labels
bug easy-pick

Comments

@mnapoli
Copy link
Member

mnapoli commented Mar 12, 2018

PHP-DI/src/Container.php

Line 112 in e06622f

ContainerInterface::class => $this,

When PHP-DI is used with a wrapper container ContainerInterface should probably point to the wrapper instead of the current instance.
@elie29
Copy link
Contributor

elie29 commented Apr 9, 2018

We can use $this->delegateContainer as wrapper is already tested

mnapoli added a commit that referenced this issue Apr 23, 2018
@mnapoli
Fix potential regression introduced when fixing #582
71a7f2e 
See 1a46970#r28689040

> The caller might expect to receive an object that is `instanceof Container`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy-pick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnapoli @elie29