statement_indentation is indenting already correct line

[VincentLanglet]

Bug report

Description

When running statement_indentation on a multiline if, if the first line is missing indentation, the following lines are getting useless extra indentation. This is especially a blocking point for #7813 since

if (true
    || false
) {
    // foo
}

is fixed to

if (
true
    || false
) {
    // foo
}

and then to

if (
    true
        || false // This line is indented for no reason
) {
    // foo
}

When I expect

if (
    true
    || false // This line is untouched
) {
    // foo
}

Runtime version

3.51.0

Configuration file

'statement_indentation' => true

Code snippet that reproduces the problem

<?php
if (
true
  || false
) {
  // foo
}

[VincentLanglet]

In the same way, I would expect

if (
    true
|| false
) {
    // foo
}

to be fixed to

if (
    true
    || false
) {
    // foo
}

but the code is unchanged.

@julienfalque, I see your name on every line of the StatementIndentationFixer.
Are you familiar with this fixer ? It seems complex to me, so far I dunno if the fix can be "easy".

[julienfalque]

Yes, I introduced it and made most of the bugfixes since then. I should take time to add comments and maybe refactor things to make it more clear. I'm having a look at this bug for now :)