PER-CS v2 support #7247
Labels
Comments
This was referenced Aug 23, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
First step here: #7249 |
This was referenced Oct 4, 2023
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this issue
Oct 24, 2023
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] PHP-CS-Fixer/PHP-CS-Fixer#7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81553 Tested-by: core-ci <typo3@b13.com> Reviewed-by: Benjamin Franzke <ben@bnf.dev> Tested-by: Benjamin Franzke <ben@bnf.dev>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this issue
Oct 24, 2023
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] PHP-CS-Fixer/PHP-CS-Fixer#7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81539 Tested-by: Benjamin Franzke <ben@bnf.dev> Reviewed-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this issue
Oct 24, 2023
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] PHP-CS-Fixer/PHP-CS-Fixer#7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81534 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benjamin Franzke <ben@bnf.dev> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Benni Mack <benni@typo3.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #6707 was merged we can start working on
@PER-CS2.0. Initial work has been done in #6547 but it's massively outdated now, that's why I am going to close that PR and move checklist here as a base for further works (should be verified).ℹ️ Official migration guide
@PER-CS2.0(and@PER-CS2.0:riskyif needed)and mark them as experimental/internal (whatever, just let people know it's not production-ready)feat: Clone PER-CS1.0 to PER-CS2.0 to prepare for adding new rules #7249single_line_empty_bodyto@PER-CS2.0#7282protected_to_private, but for enums onlyno_singleline_whitespace_before_semicolons, but for arrow functions onlyfnand=>must be surrounded by a space=>must be placed after a new line=>must be indented once when placed after a new lineEach checklist item should be provided as separate PR (with additions to integration test), so review process is easier and things may go forward faster.
The text was updated successfully, but these errors were encountered: