Why are the indentation rules so restrictive?

[Rasmus-Bertell]

I'm trying to understand why the indentation rules are so limited? I like to follow the linux kernel spec and usually have 8 space indentation for my personal projects. It's frustrating that there's a function for setting the indentation but it only accepts a limited set of options.

[julienfalque]

Can you be more specific about the limitation you are talking about? What prevents you from defining indentation as expected?

[kubawerlos]

@julienfalque there is this limitation to what indent can be.

[Wirone]

@keradus the answer to @SpacePossum's question is in the discussion - Linux kernel. I know it's not PHP, but does it really matter? Also, I don't understand your reasoning. Indentation is a person/team/project specific thing, it's configurable and totally separated from the rules (I mean: it does not affect the logic, it's only used by indentation-aware rules). I don't see a reason to limit it in any way unless it's causing problems to Fixer's flow (but I believe it's not).

I am in favor of getting rid of this limitation if it does not affect the tool (I will check it later, AFK now).

[keradus]

it in any way unless it's causing problems to Fixer's flow (but I believe it's not).

we supported 4 spaces initially. added tabs caused problems (not limited to single rule class). then adding 2 spaces also added problems.

I'm against adding anything that I do not consider a good practice unless there is strong community (yes, PHP community).
If we have strong community using 8 spaces we can consider allowing it (with bunch of tests and hoping for no need for other fixes needed - at least mimic tests/Fixtures/Integration/set/@PSR12_whitespaces.test*.php but with new indent option). still no value in 7 spaces being allowed.

If individual wants to use some style that is not common, they are fully encouraged to do so, as we allow for custom rules.

[Rasmus-Bertell]

please go with custom rule to fit your personal needs.

I'm not so experienced with this but can a custom rule overwrite the ->setIndent() setting?

If it can then, while not ideal in my opinion, this can be solved using a custom rule. I would just have to copy the rule to all my projects.

[keradus]

very good point.
so, let's conclude on need of community (or lack of it) part, and potentially extend all the tests.