PSR-12 §6.1: Unary operators

[wimski]

Let me start by quoting the opening line of the README.md (emphasis is mine):

The PHP Coding Standards Fixer (PHP CS Fixer) tool fixes your code to follow standards

This would let one to assume that when applying a ruleset from a specific standard, the code would only be fixed according to that standard. This is no longer the case for spaces surrounding unary operators in PSR-12 since this PR was merged.

The PSR-12 standard says the following about spaces surrounding unary operators:

6. Operators

When space is permitted around an operator, multiple spaces MAY be used for readability purposes.
All operators not described here are left undefined.

6.1 Unary operators

The increment/decrement operators MUST NOT have any space between the operator and operand.
Type casting operators MUST NOT have any space within the parentheses.

If the tool would follow the standard for the PSR-12 ruleset, you would expect increment/decrement and type casting operators to be fixed by a 'unary operator spaces' rule, but nothing else. Any further changes, which are not defined in the standard, should be up to configuration by the user.

Perhaps the rule could be made configurable in this kind of fashion:

// Apply to all
[
    'unary_operator_spaces' => true, 
];

// Apply to none
[
    'unary_operator_spaces' => false,
];

// Apply to selection (PSR-12 default example)
[
    'unary_operator_spaces' => [
        'increment',
        'decrement',
        'type_casting_parentheses',
    ],
];

---

Related sources:

• feat: PSR12 - configure unary_operator_spaces #7388
• Reference assignment operator =& gets broken up #7303
• unary_operator_spaces included in PSR-12 and PER-CS #7504

[keradus]

We need config for the rule then. would you like to raise PR for it, @wimski ?

[wimski]

@keradus I can certainly give this a go when I find the time. And I will first have to familiarize myself with this code-base and how configuration is done for comparable rules.

What would be the defaults for the various rulesets?

[Wirone]

What would be the defaults for the various rulesets?

IMHO unary_operator_spaces should enable only what's included in PSR/PER for their respective rulesets, and enable everything for PhpCsFixer ruleset (to achieve what's configured now). I don't know how to handle Symfony ruleset, but I would go with all operators too (so PhpCsFixer would inherit it) - @nicolas-grekas can you confirm?

[keradus]

I can confirm Sf codebase follows it for all operators

[keradus]

Closed by merge of #7626