-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
/
PhpdocToReturnTypeFixer.php
207 lines (177 loc) · 5.78 KB
/
PhpdocToReturnTypeFixer.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
<?php
declare(strict_types=1);
/*
* This file is part of PHP CS Fixer.
*
* (c) Fabien Potencier <fabien@symfony.com>
* Dariusz Rumiński <dariusz.ruminski@gmail.com>
*
* This source file is subject to the MIT license that is bundled
* with this source code in the file LICENSE.
*/
namespace PhpCsFixer\Fixer\FunctionNotation;
use PhpCsFixer\AbstractPhpdocToTypeDeclarationFixer;
use PhpCsFixer\FixerDefinition\CodeSample;
use PhpCsFixer\FixerDefinition\FixerDefinition;
use PhpCsFixer\FixerDefinition\FixerDefinitionInterface;
use PhpCsFixer\FixerDefinition\VersionSpecification;
use PhpCsFixer\FixerDefinition\VersionSpecificCodeSample;
use PhpCsFixer\Tokenizer\CT;
use PhpCsFixer\Tokenizer\Token;
use PhpCsFixer\Tokenizer\Tokens;
/**
* @author Filippo Tessarotto <zoeslam@gmail.com>
*/
final class PhpdocToReturnTypeFixer extends AbstractPhpdocToTypeDeclarationFixer
{
/**
* @var array<int, array<int, int|string>>
*/
private $excludeFuncNames = [
[T_STRING, '__construct'],
[T_STRING, '__destruct'],
[T_STRING, '__clone'],
];
/**
* @var array<string, true>
*/
private $skippedTypes = [
'mixed' => true,
'resource' => true,
'null' => true,
];
/**
* {@inheritdoc}
*/
public function getDefinition(): FixerDefinitionInterface
{
return new FixerDefinition(
'EXPERIMENTAL: Takes `@return` annotation of non-mixed types and adjusts accordingly the function signature. Requires PHP >= 7.0.',
[
new CodeSample(
'<?php
/** @return \My\Bar */
function f1()
{}
/** @return void */
function f2()
{}
'
),
new VersionSpecificCodeSample(
'<?php
/** @return object */
function my_foo()
{}
',
new VersionSpecification(70200)
),
new CodeSample(
'<?php
/** @return Foo */
function foo() {}
/** @return string */
function bar() {}
',
['scalar_types' => false]
),
new VersionSpecificCodeSample(
'<?php
final class Foo {
/**
* @return static
*/
public function create($prototype) {
return new static($prototype);
}
}
',
new VersionSpecification(80000)
),
],
null,
'This rule is EXPERIMENTAL and [1] is not covered with backward compatibility promise. [2] `@return` annotation is mandatory for the fixer to make changes, signatures of methods without it (no docblock, inheritdocs) will not be fixed. [3] Manual actions are required if inherited signatures are not properly documented.'
);
}
/**
* {@inheritdoc}
*/
public function isCandidate(Tokens $tokens): bool
{
return $tokens->isAnyTokenKindsFound([T_FUNCTION, T_FN]);
}
/**
* {@inheritdoc}
*
* Must run before FullyQualifiedStrictTypesFixer, NoSuperfluousPhpdocTagsFixer, PhpdocAlignFixer, ReturnTypeDeclarationFixer.
* Must run after AlignMultilineCommentFixer, CommentToPhpdocFixer, PhpdocIndentFixer, PhpdocScalarFixer, PhpdocToCommentFixer, PhpdocTypesFixer.
*/
public function getPriority(): int
{
return 13;
}
protected function isSkippedType(string $type): bool
{
return isset($this->skippedTypes[$type]);
}
/**
* {@inheritdoc}
*/
protected function applyFix(\SplFileInfo $file, Tokens $tokens): void
{
if (\PHP_VERSION_ID >= 80000) {
unset($this->skippedTypes['mixed']);
}
for ($index = $tokens->count() - 1; 0 < $index; --$index) {
if (!$tokens[$index]->isGivenKind([T_FUNCTION, T_FN])) {
continue;
}
$funcName = $tokens->getNextMeaningfulToken($index);
if ($tokens[$funcName]->equalsAny($this->excludeFuncNames, false)) {
continue;
}
$docCommentIndex = $this->findFunctionDocComment($tokens, $index);
if (null === $docCommentIndex) {
continue;
}
$returnTypeAnnotation = $this->getAnnotationsFromDocComment('return', $tokens, $docCommentIndex);
if (1 !== \count($returnTypeAnnotation)) {
continue;
}
$typeInfo = $this->getCommonTypeFromAnnotation(current($returnTypeAnnotation), true);
if (null === $typeInfo) {
continue;
}
[$returnType, $isNullable] = $typeInfo;
$startIndex = $tokens->getNextTokenOfKind($index, ['{', ';']);
if ($this->hasReturnTypeHint($tokens, $startIndex)) {
continue;
}
if (!$this->isValidSyntax(sprintf('<?php function f():%s {}', $returnType))) {
continue;
}
$endFuncIndex = $tokens->getPrevTokenOfKind($startIndex, [')']);
$tokens->insertAt(
$endFuncIndex + 1,
array_merge(
[
new Token([CT::T_TYPE_COLON, ':']),
new Token([T_WHITESPACE, ' ']),
],
$this->createTypeDeclarationTokens($returnType, $isNullable)
)
);
}
}
/**
* Determine whether the function already has a return type hint.
*
* @param int $index The index of the end of the function definition line, EG at { or ;
*/
private function hasReturnTypeHint(Tokens $tokens, int $index): bool
{
$endFuncIndex = $tokens->getPrevTokenOfKind($index, [')']);
$nextIndex = $tokens->getNextMeaningfulToken($endFuncIndex);
return $tokens[$nextIndex]->isGivenKind(CT::T_TYPE_COLON);
}
}