Feature/added logger to the new project #155
Merged
+538
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milmilkat
force-pushed
the
feature/added-logger-to-the-new-project
branch
from
acfa54f to
d9d2c6b
Compare
Toxantron
reviewed
Aug 5, 2022
milmilkat
force-pushed
the
feature/added-logger-to-the-new-project
branch
from
efa82aa to
73f6059
Compare
Toxantron
reviewed
Aug 8, 2022
There was a problem hiding this comment.
I know you we had to remove ParallelOperations, but we need some replacement to prevent once created RemoteAppenders from flooding the memory if no one flushes the messages or removes the appenders. I'd say every log appender that has not been checked for more than 30s can be considered dead.
|
@Toxantron I am not sure if I could understand you correctly, but take a look and let me know if further ammendents are required. |
milmilkat
force-pushed
the
feature/added-logger-to-the-new-project
branch
3 times, most recently
from
6d8920b to
31a1e47
Compare
milmilkat
force-pushed
the
feature/added-logger-to-the-new-project
branch
from
31a1e47 to
dcf6a01
Compare
Toxantron
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logger but created a separate MR for you to see if it actually makes sense or not