Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to get rid of plaintext password in property file (Oxalis.conf). #634

Open
jaskiratsingh1792 opened this issue Sep 5, 2023 · 1 comment
Labels
Under review Issues currently being reviewed

Comments

@jaskiratsingh1792
Copy link

"oxalis.conf" contains passwords as plain text, which makes the application vulnerable as someone having access to the system can read/modify it.
eg.
oxalis.keystore {
path="xxxx/xxxxxx.jks"
password = "xxxxxabc"
key.alias = cert
key.password = "xxxxxabc"
}

As this appears to be a security vulnerability, can we expect an alternate approach/solution for it ?

@seciq
Copy link

seciq commented Oct 24, 2023

@jaskiratsingh1792 The support is already there and you can pass secrets through environment variables.

Here is an example of oxalis.conf where the secret is passed through OXALIS_KEYSTORE_PASSWORD environment variable:

...
oxalis.keystore.path = oxalis-test.p12
oxalis.keystore.password = ${?OXALIS_KEYSTORE_PASSWORD}
oxalis.keystore.key.alias = cert
oxalis.keystore.key.password = ${?OXALIS_KEYSTORE_PASSWORD}
..

More details

Oxalis is using the com.typesafe.config.ConfigFactory to load the configuration. Here is the official documentation for config overrides.

@aaron-kumar aaron-kumar added the Under review Issues currently being reviewed label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under review Issues currently being reviewed
Projects
None yet
Development

No branches or pull requests

3 participants