Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Vendoring charset-normalizer in pip #456

Closed
bluetech opened this issue Apr 18, 2024 · 4 comments
Closed

[Proposal] Vendoring charset-normalizer in pip #456

bluetech opened this issue Apr 18, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@bluetech
Copy link

While looking into pip's startup time, I found that replacing chardet with charset-normalizer improves things. pip has a policy of vendoring its dependencies, so I'd like to propose to pip to change its vendoring from chardet to charset-normalizer.

Before I do it, I'd like to ask if you are OK with this?

See pip discussion here: pypa/pip#4768 (comment)

@bluetech bluetech added the enhancement New feature or request label Apr 18, 2024
@Ousret
Copy link
Collaborator

Ousret commented Apr 18, 2024

I am OK with this.

While speaking performances, maybe in a not too distant future, pip may consider replacing requests for niquests.

Regards,

@Ousret Ousret closed this as completed Apr 18, 2024
@notatallshaw
Copy link

pip may consider replacing requests for niquests

I'm not a pip maintainer, but pip generally requires having pure Python dependencies only, taking a quick look at niquests dependencies I see qh3 requires compiling some C code, this wouldn't at the moment fit pip's distribution model.

@Ousret
Copy link
Collaborator

Ousret commented Apr 18, 2024

qh3 is optional.

@notatallshaw
Copy link

notatallshaw commented Apr 18, 2024

Well, someone would need to submit a proposal/PR and it would need to be considered by pip maintainers.

But, fyi, pip's resources are very low at the moment so maintainers are very cautious about changes that could cause breakage/support issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants