Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bare exceptions #52

Open
girotobial opened this issue Jun 21, 2022 · 0 comments
Open

Remove bare exceptions #52

girotobial opened this issue Jun 21, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@girotobial
Copy link

girotobial commented Jun 21, 2022

The codebase is littered with bare exceptions.

try:
    foo()
except:
    something_else()

At best this is preventing keyboard and system exits. At worst it is masking a lot of bugs. They should be replaced with a named exception type, or at the very least Exception.

I.e

try:
    foo()
except ValueError:
    something_else()

or

try:
    foo()
except Exception:
    something_else()
@girotobial girotobial added bug Something isn't working good first issue Good for newcomers labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant