New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove role=switch on switches #1152
Comments
Hi @Aniort, This change was provided by Bootstrap with some interesting discussions about it here. TLDR :
They also based their opinion on MDN first link, MDN second link and on w3c recommendations. To summarize, What do you think about it ? Do we need to keep these changes ? |
According to @Aniort , the |
after futher more readings, we can close this PR because Bootstrap has made a good choice for the switches, so let's resume like that ! |
Prerequisites
Describe the issue
on https://boosted.orange.com/docs/5.1/forms/checks-radios/#switches page, we need to remove the role=switch on these switches because role=switch needs to be used with an aria-check attribute
So to be more robust and to ensure more progressive enhancement, just remove the role=switch
references: https://adrianroselli.com/2019/03/under-engineered-toggles.html and https://adrianroselli.com/2021/10/switch-role-support.html
Reduced test cases
https://adrianroselli.com/2021/10/switch-role-support.html
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Firefox
What version of Boosted are you using?
5.1.
The text was updated successfully, but these errors were encountered: