Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed https redirection issue #263

Closed
wants to merge 0 commits into from
Closed

Fixed https redirection issue #263

wants to merge 0 commits into from

Conversation

clarkbains
Copy link

This fixes #262, by removing the duplicated part of the path.

@clarkbains
Copy link
Author

Travis failed with the following, maybe this is something that needs to be looked into?
Address in use wouldn't have been caused by me.

1) Target with a hostname Should have the host header passed to the target:

     Uncaught Error: listen EADDRINUSE :::54674

      at Server.setupListenHandle [as _listen2] (net.js:1360:14)

      at listenInCluster (net.js:1401:12)

      at Server.listen (net.js:1485:7)

      at test/test_hostheader.js:135:12

      at Promise._execute (node_modules/bluebird/js/release/debuggability.js:384:9)

      at Promise._resolveFromExecutor (node_modules/bluebird/js/release/promise.js:518:18)

      at new Promise (node_modules/bluebird/js/release/promise.js:103:10)

      at testServer (test/test_hostheader.js:127:10)

      at Context.<anonymous> (test/test_hostheader.js:28:5)

  2) Target with a hostname Should not have the host header passed to the target:

     Uncaught Error: listen EADDRINUSE :::54674

      at Server.setupListenHandle [as _listen2] (net.js:1360:14)

      at listenInCluster (net.js:1401:12)

      at Server.listen (net.js:1485:7)

      at test/test_hostheader.js:135:12

      at Promise._execute (node_modules/bluebird/js/release/debuggability.js:384:9)

      at Promise._resolveFromExecutor (node_modules/bluebird/js/release/promise.js:518:18)

      at new Promise (node_modules/bluebird/js/release/promise.js:103:10)

      at testServer (test/test_hostheader.js:127:10)

      at Context.<anonymous> (test/test_hostheader.js:47:5)

  3) Target with a hostname Should return 404 after route is unregister:

     Uncaught Error: listen EADDRINUSE :::54674

      at Server.setupListenHandle [as _listen2] (net.js:1360:14)

      at listenInCluster (net.js:1401:12)

      at Server.listen (net.js:1485:7)

      at test/test_hostheader.js:135:12

      at Promise._execute (node_modules/bluebird/js/release/debuggability.js:384:9)

      at Promise._resolveFromExecutor (node_modules/bluebird/js/release/promise.js:518:18)

      at new Promise (node_modules/bluebird/js/release/promise.js:103:10)

      at testServer (test/test_hostheader.js:127:10)

      at Context.<anonymous> (test/test_hostheader.js:67:5)```

@clarkbains clarkbains closed this Dec 22, 2020
@manast manast reopened this Dec 23, 2020
@manast
Copy link
Member

manast commented Dec 23, 2020

If you still want I can merge this now, very sorry for the delay.

@clarkbains
Copy link
Author

I realized I accidentally included some other changes that probably shouldn't be included, do you mind if I made a different pr?

@clarkbains clarkbains closed this Dec 23, 2020
@clarkbains clarkbains mentioned this pull request Dec 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Http -> Https redirects when path is specified redirrect incorrectly
2 participants
@clarkbains @manast