Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Logs - How to ensure they are cleaned after job completion? #1330

Closed
arnaudbesnier opened this issue May 31, 2019 · 1 comment
Closed

Comments

@arnaudbesnier
Copy link

arnaudbesnier commented May 31, 2019

Description

Hi,

I implemented the latest log feature.
Seems to work as expected 💪

I observe that those logs persist on Redis (even for completed jobs).
Is it the expected behaviour?

I didn't find a way to configure the automatic cleaning on job completion in the documentation and didn't find any traces of such implementation in the diff:
v3.8.1...v3.9.0

As we have a lot of jobs executed in production, I don't want to "explode" my Redis storage.

Thank you and keep up the good work!!

Bull version

v3.9.1

@arnaudbesnier arnaudbesnier changed the title Job Logs - How to ensure they are cleaned after job completion Job Logs - How to ensure they are cleaned after job completion? May 31, 2019
@manast
Copy link
Member

manast commented May 31, 2019

that was an oversight from me part, of course job logs should be deleted when the job itself is deleted.

@manast manast closed this as completed in 8522bfa Jun 1, 2019
manast added a commit that referenced this issue Jun 1, 2019
…toremove

fix: remove logs when autoremoving jobs fixes #1330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants