Fix check for supported file types #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for supported file types was added here - OptimalBits#1186. It’s checking for `supportedFileTypes.indexOf(path.extname(handler)) !== -1 ` but indexOf return a number `-1` not a string `’-`’`, so this check was always true. Updated to the number `-1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a check for supported file types added but it’s checking for
supportedFileTypes.indexOf(path.extname(handler)) !== '-1',indexOfreturns a number-1not a string'-1', so this check was always true.Updated to number
-1instead of string.