Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate Solc inputs to verify different proxy contracts #754

Open
ericglau opened this issue Mar 2, 2023 · 1 comment · May be fixed by #755
Open

Use separate Solc inputs to verify different proxy contracts #754

ericglau opened this issue Mar 2, 2023 · 1 comment · May be fixed by #755

Comments

@ericglau
Copy link
Member

ericglau commented Mar 2, 2023

Currently the Solc input for all proxy-related contracts are packaged into one build-info.json file. When using this to verify source code on Etherscan, this causes the contracts for every different proxy kind to be included.

For example, even if the user is only using ERC1967Proxy, the source code for TransparentUpgradeableProxy would also be included in the verified source code.

To improve this, we should verify each proxy-related contract using its own Solc input for that contract and its dependencies only.
@Amxx
Copy link
Contributor

Amxx commented Mar 2, 2023

For example, even if the user is only using ERC1967Proxy, the source code for TransparentUpgradeableProxy would also be included in the verified source code.

Good to know. This is throwing the feature detection way off!

@ericglau ericglau linked a pull request Mar 2, 2023 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use separate Solc inputs to verify different proxy contracts ericglau/openzeppelin-upgrades
2 participants
@Amxx @ericglau